Closed Bug 1257105 Opened 4 years ago Closed 4 years ago

test_resize_move_windows.html should use Promise

Categories

(Core :: DOM: Core & HTML, defect)

47 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

Attached patch promise.patchSplinter Review
No description provided.
Attachment #8731104 - Flags: review?(ehsan)
Blocks: 1255138
Comment on attachment 8731104 [details] [diff] [review]
promise.patch

Review of attachment 8731104 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/bugs/test_resize_move_windows.html
@@ +74,5 @@
>   * If times < 0, the event loop will be hitten as long as the condition isn't
>   * true or the test doesn't time out.
>   */
> +function hitEventLoop(condition, test, times) {
> +  return new Promise(function(r, rr) {

I have never seen anyone name these r and rr!  How about resolve and reject?  :-)
Attachment #8731104 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/824d6ff63d10
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
No longer blocks: 1255138
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.