test_resize_move_windows.html should use Promise

RESOLVED FIXED in Firefox 48

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

47 Branch
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8731104 [details] [diff] [review]
promise.patch
Attachment #8731104 - Flags: review?(ehsan)
(Assignee)

Updated

2 years ago
Blocks: 1255138

Comment 1

2 years ago
Comment on attachment 8731104 [details] [diff] [review]
promise.patch

Review of attachment 8731104 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/bugs/test_resize_move_windows.html
@@ +74,5 @@
>   * If times < 0, the event loop will be hitten as long as the condition isn't
>   * true or the test doesn't time out.
>   */
> +function hitEventLoop(condition, test, times) {
> +  return new Promise(function(r, rr) {

I have never seen anyone name these r and rr!  How about resolve and reject?  :-)
Attachment #8731104 - Flags: review?(ehsan) → review+

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/824d6ff63d10
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
No longer blocks: 1255138
You need to log in before you can comment on or make changes to this bug.