Closed
Bug 1257129
Opened 10 years ago
Closed 10 years ago
Uninitialized member in SSLv2ClientHelloTestF
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(firefox48 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | affected |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
(Blocks 1 open bug)
Details
(Keywords: coverity)
Attachments
(1 file)
|
1.20 KB,
patch
|
franziskus
:
review+
|
Details | Diff | Splinter Review |
*** CID 1356347: Uninitialized members (UNINIT_CTOR)
/external_tests/ssl_gtest/ssl_v2_client_hello_unittest.cc: 165 in nss_test::SSLv2ClientHelloTestF::SSLv2ClientHelloTestF()()
159
160 class SSLv2ClientHelloTestF : public TlsConnectTestBase
161 {
162 public:
163 SSLv2ClientHelloTestF()
164 : TlsConnectTestBase(STREAM, 0)
>>> CID 1356347: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "filter_" is not initialized in this constructor nor in any functions that it calls.
165 { }
166
167 SSLv2ClientHelloTestF(Mode mode, uint16_t version)
168 : TlsConnectTestBase(mode, version)
169 { }
170
*** CID 1356346: Uninitialized members (UNINIT_CTOR)
/external_tests/ssl_gtest/ssl_v2_client_hello_unittest.cc: 169 in nss_test::SSLv2ClientHelloTestF::SSLv2ClientHelloTestF(nss_test::Mode, unsigned short)()
163 SSLv2ClientHelloTestF()
164 : TlsConnectTestBase(STREAM, 0)
165 { }
166
167 SSLv2ClientHelloTestF(Mode mode, uint16_t version)
168 : TlsConnectTestBase(mode, version)
>>> CID 1356346: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "filter_" is not initialized in this constructor nor in any functions that it calls.
169 { }
170
171 void
172 SetUp()
173 {
174 TlsConnectTestBase::SetUp();
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8731172 -
Flags: review?(franziskuskiefer)
|
|
Assignee | |
Updated•10 years ago
|
Blocks: nss-coverity
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8731172 [details] [diff] [review]
0001-Bug-1257129-Initialize-all-members-in-SSLv2ClientHel.patch
Review of attachment 8731172 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8731172 -
Flags: review?(franziskuskiefer) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•