Closed
Bug 1257213
Opened 10 years ago
Closed 10 years ago
Update service should ignore temporary add-ons when checking for incompatible add-ons
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | affected |
People
(Reporter: mossop, Unassigned)
Details
The update service checks for any add-ons that will be made incompatible by the detected update. It should ignore temporary add-ons since those go away after a restart. Same for experiments.
| Reporter | ||
Comment 1•10 years ago
|
||
Hmm, also system add-ons.
Comment 3•10 years ago
|
||
(In reply to Dave Townsend [:mossop] from comment #1)
> Hmm, also system add-ons.
It already skips add-ons that are SCOPE_APPLICATION. Are there others that should also be skipped and if so, how would they be detected?
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsUpdateService.js#2636
| Reporter | ||
Comment 4•10 years ago
|
||
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> (In reply to Dave Townsend [:mossop] from comment #1)
> > Hmm, also system add-ons.
>
> It already skips add-ons that are SCOPE_APPLICATION. Are there others that
> should also be skipped and if so, how would they be detected?
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/
> nsUpdateService.js#2636
System add-ons locations have addon.isSystem == true.
Temporary add-ons have addon.scope == AddonManager.SCOPE_TEMPORARY.
Neither of those should be taken into account, system add-ons will get replaced by any app upgrade that changes version number, temporary add-ons only remain installed until the application is restarted.
Flags: needinfo?(dtownsend)
Comment 5•10 years ago
|
||
The app update add-on compatibility check will be removed in bug 1262880
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•