Closed
Bug 1257389
Opened 8 years ago
Closed 8 years ago
ConvertJSValueToByteString should use fallible allocation
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: khuey, Assigned: khuey)
Details
Attachments
(1 file)
762 bytes,
patch
|
bzbarsky
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
I found at least one dump on Socorro that crashed here. There are probably more but stackwalking fails, so I had to grovel around in the minidump to find the return address and pin it on ConvertJSValueToByteString.
Attachment #8731493 -
Flags: review?(bzbarsky)
Comment 1•8 years ago
|
||
Comment on attachment 8731493 [details] [diff] [review] Patch Good catch. r=me
Attachment #8731493 -
Flags: review?(bzbarsky) → review+
Comment 3•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb4fb4fef6d4
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8731493 [details] [diff] [review] Patch Simple OOM fix to use fallible allocation on a content-controlled string. Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: Slightly more OOM crashes [Describe test coverage new/current, TreeHerder]: This code path is well tested, used by many WebIDL bindings [Risks and why]: low risk [String/UUID change made/needed]: N/A
Attachment #8731493 -
Flags: approval-mozilla-beta?
Attachment #8731493 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
status-firefox46:
--- → affected
status-firefox47:
--- → affected
Comment 5•8 years ago
|
||
Comment on attachment 8731493 [details] [diff] [review] Patch Less crashes, taking it Should be in 46 beta 5
Attachment #8731493 -
Flags: approval-mozilla-beta?
Attachment #8731493 -
Flags: approval-mozilla-beta+
Attachment #8731493 -
Flags: approval-mozilla-aurora?
Attachment #8731493 -
Flags: approval-mozilla-aurora+
Comment 6•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/f8845ecc6bee
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/391e44f7849f
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•