1257389 - ConvertJSValueToByteString should use fallible allocation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

I found at least one dump on Socorro that crashed here.  There are probably more but stackwalking fails, so I had to grovel around in the minidump to find the return address and pin it on ConvertJSValueToByteString.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8731493 [details] [diff] [review]
Patch

Good catch.  r=me

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb4fb4fef6d4

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb4fb4fef6d4

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8731493 [details] [diff] [review]
Patch

Simple OOM fix to use fallible allocation on a content-controlled string.

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Slightly more OOM crashes
[Describe test coverage new/current, TreeHerder]: This code path is well tested, used by many WebIDL bindings
[Risks and why]: low risk
[String/UUID change made/needed]: N/A

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8731493 [details] [diff] [review]
Patch

Less crashes, taking it
Should be in 46 beta 5

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f8845ecc6bee

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/391e44f7849f