1257410 - xpcom/tests/windows/TestCOM.cpp(57): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'nsrefcnt'

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Gregory Szorc [:gps]]

The C4477 warning is being enabled in bug 1124033 and occurs twice in TestCOM.cpp. When building with warnings as errors with VS2015u1, this causes build failure and thus blocks the transition to VS2015.

xpcom/tests/windows/TestCOM.cpp(57): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'nsrefcnt'
xpcom/tests/windows/TestCOM.cpp(57): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
xpcom/tests/windows/TestCOM.cpp(57): note: consider using '%lld' in the format string
xpcom/tests/windows/TestCOM.cpp(57): note: consider using '%Id' in the format string
xpcom/tests/windows/TestCOM.cpp(57): note: consider using '%I64d' in the format string
xpcom/tests/windows/TestCOM.cpp(65): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'nsrefcnt'
xpcom/tests/windows/TestCOM.cpp(65): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
xpcom/tests/windows/TestCOM.cpp(65): note: consider using '%lld' in the format string
xpcom/tests/windows/TestCOM.cpp(65): note: consider using '%Id' in the format string
xpcom/tests/windows/TestCOM.cpp(65): note: consider using '%I64d' in the format string

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

nsrefcnt is a uintptr_t. We could probably just use %p here. Hex vs. decimal shouldn't actually matter here and that'll make it the right size on 32 and 64 bit.

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1257410 - Use %p and cast in printf to avoid C4477 on VS2015; r?khuey

Review commit: https://reviewboard.mozilla.org/r/41511/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41511/

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8733014 [details]
MozReview Request: Bug 1257410 - Use %p and cast in printf to avoid C4477 on VS2015; r?khuey

https://reviewboard.mozilla.org/r/41511/#review37943

Comment 4

[Gregory Szorc [:gps]]

Try was not amused:

 13:44:03     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/xpcom/tests/windows/TestCOM.cpp(57): error C2220: warning treated as error - no 'object' file generated
 13:44:03     INFO -  Warning: C4477 in c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\xpcom\tests\windows\TestCOM.cpp: 'printf' : format string '%p' requires an argument of type 'void *', but variadic argument 1 has type 'nsrefcnt'
 13:44:03     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/xpcom/tests/windows/TestCOM.cpp(57): warning C4477: 'printf' : format string '%p' requires an argument of type 'void *', but variadic argument 1 has type 'nsrefcnt'
 13:44:03     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/xpcom/tests/windows/TestCOM.cpp(57): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
 13:44:03     INFO -  Warning: C4477 in c:\builds\moz2_slave\try-w64-d-00000000000000000000\build\src\xpcom\tests\windows\TestCOM.cpp: 'printf' : format string '%p' requires an argument of type 'void *', but variadic argument 1 has type 'nsrefcnt'
 13:44:03     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/xpcom/tests/windows/TestCOM.cpp(65): warning C4477: 'printf' : format string '%p' requires an argument of type 'void *', but variadic argument 1 has type 'nsrefcnt'
 13:44:03     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/xpcom/tests/windows/TestCOM.cpp(65): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
 13:44:03     INFO -  c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/obj-firefox/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/config/nsinstall.py -t -m 644 'testcompnoaslr.dll' '../../../_tests/xpcshell/xpcom/tests/unit/components'
13:44:03 INFO - c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/src/config/rules.mk:918: recipe for target 'TestCOM.obj' failed

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

You can cast to void* then to use %p.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8733014 [details]
MozReview Request: Bug 1257410 - Use %p and cast in printf to avoid C4477 on VS2015; r?khuey

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41511/diff/1-2/

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://reviewboard.mozilla.org/r/41511/#review37995

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdf79a0b9a3b

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cdf79a0b9a3b