Closed Bug 1257451 Opened 8 years ago Closed 7 years ago

mach run and mochitest has inconsistent debugger argument syntax debugger-args and debugparams

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: kanru, Unassigned)

Details

Attachments

(1 file)

Bug 1257451 - Make |mach run| use --debugger-args instead of --debugparams, like the mochitest/reftest commands do.
59 bytes, text/x-review-board-request
gps
: review+
Details 
|mach run| accepts --debbugparams and |mach mochitest| accepts --debugger-args

It's confusing that one works and the other doesn't.
Comment on attachment 8859877 [details]
Bug 1257451 - Make |mach run| use --debugger-args instead of --debugparams, like the mochitest/reftest commands do.

https://reviewboard.mozilla.org/r/131852/#review134978

I suspect some people will be caught off guard by this backwards incompatible change. You may want to consider still accepting the old argument, but printing a warning and forwarding the value to `args.debugger_args`.
Attachment #8859877 - Flags: review?(gps) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f866afd3d2d2
Make |mach run| use --debugger-args instead of --debugparams, like the mochitest/reftest commands do. r=gps
https://hg.mozilla.org/mozilla-central/rev/f866afd3d2d2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.