1257472 - ice candidate parsing error when icetransports is set to relay in chrome

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Philipp Hancke]

Attachment: aboutWebrtc.html

from https://github.com/andyet/SimpleWebRTC/issues/414

Apparently Firefox has issues with the relay candidate chrome sends:
Error parsing attribute: a=candidate:838043334 1 udp 41885439 104.130.195.95 32968 typ relay raddr 0.0.0.0 rport 0 generation 0


does not seem to be a regression caused by chromes new per-candidate ufrag at least.
(ignore the 'Message does not correspond to any registered stun ctx' in the attached log - the TURN server doesn't care about permissions)

Comment 1

[Philipp Hancke]

alternatively easy to reproduce with apprtc by setting ?it=relay

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Per original report fippo links to: "I think the problem occurs because Chrome sets raddr 0.0.0.0 and rport 0."

Comment 3

[Maire Reavy [:mreavy]]

Byron, Nils -- This is probably easy to fix (I know: "famous last words"), and I'd like to get a fix for this done quickly.  Can one you take this and the other review the fix?  Thanks.

Comment 4

[Byron Campen [:bwc]]

This is probably where we're rejecting this:

https://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/ice/ice_parser.c#304

Comment 5

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1257472: Forgive rport of 0. r?drno

Review commit: https://reviewboard.mozilla.org/r/40799/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40799/

Comment 6

[Eric Rescorla (:ekr)]

Comment on attachment 8731734 [details]
MozReview Request: Bug 1257472: Forgive rport of 0. r?drno

https://reviewboard.mozilla.org/r/40799/#review37309

LGTM

Comment 7

[Nils Ohlmeier [:drno]]

Comment on attachment 8731734 [details]
MozReview Request: Bug 1257472: Forgive rport of 0. r?drno

https://reviewboard.mozilla.org/r/40799/#review37369

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0a0cbca83706

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0a0cbca83706

Comment 10

[Maire Reavy [:mreavy]]

Byron -- can you request uplift to Aurora and Beta?   Beta 4 should go to build today.  I'd love to get it into Beta 4, but if we miss 4, let's make 5 for sure.  Thanks!

Comment 11

[Byron Campen [:bwc]]

Comment on attachment 8731734 [details]
MozReview Request: Bug 1257472: Forgive rport of 0. r?drno

Approval Request Comment
[Feature/regressing bug #]:

   Present since webrtc landed.

[User impact if declined]:

   Connectivity failures when interoperating with Chrome.

[Describe test coverage new/current, TreeHerder]:

   No new coverage.

[Risks and why]:

   Extremely low, we are simply being more forgiving on the candidate parse.

[String/UUID change made/needed]:

   None.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8731734 [details]
MozReview Request: Bug 1257472: Forgive rport of 0. r?drno

Improve webrtc, taking it.
Should be in 46 beta 5

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f601dc16ab45

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/243d8088e03b