1257538 - Allow more lines of text empty panel descriptions before resizing font

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: empty_panels.png

Compare history (on the left) with bookmarks (on the right): there's plenty of space available, but the font is reduced to an hardly readable size.

Comment 1

[farhanpatel.17]

Attachment: Pull Request

I opted to set the number of lines to automatic. I can set this to 5 or something if you think that works better. I dont have the locals setup on my dev yet. Hopefully someone else can respond with a screenshot of exactly how it looks with the change.

Comment 2

[Brian Nicholson (:bnicholson)]

I'm actually having trouble reproducing this bug. I've tried looking at the empty panels on the 4s, 5s, and 6s, but the fonts look the same on all of them.

Did this get fixed somewhere else, or are there some STR I need to follow?

Comment 3

[farhanpatel.17]

Try doubling the text in the label if you dont want to try a specfic locale. You can see it easily. If the text is longer than 2 lines than `welcomeLabel.adjustsFontSizeToFitWidth = true` will reduce the size to make the text fit into the 2 lines. The font is still the same but the text is so small it makes it hard to read.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8740518 [details] [review]
Pull Request

Er, somehow missed that the screenshot is in a different language. Makes sense to me!

Comment 5

[Stephan Leroux [:sleroux]]

master 8db5b867a878af7d09fb52cb5dc185f0499254cb

Comment 6

[Stephan Leroux [:sleroux]]

v4.x v4.x 6f49c25