Location bar displays many duplicates in suggestions when I delete items




Address Bar
2 years ago
2 years ago


(Reporter: arni2033, Unassigned)




Firefox Tracking Flags

(Not tracked)


(Whiteboard: [fxsearch], URL)

User Story

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
>>>   My Info:   Win7_64, Nightly 50, 32bit, ID 20160715063552 (2016-07-15)

There're 2 scenarios:
A) Duplicate suggestions don't disappear until ~0.5s after last keyboard activity, which could
   lead to many duplicate suggestions displayed simultaneously while user types the text.
   See STR_1 for one possible scenario. Use comment 0 to create bookmarks.
B) Duplicate suggestions don't disappear in the end of scrollable list. STR_2
Scenario (B) has changed several times, but I don't have the time to track every change in behavior.

STR_1 (A):
0. Launch new profile. Open new tab, close other tabs.
   Delete bookmarks & history, create 19 bookmarks "http://a.b/#i" for i in 1..19  (comment 0)
1. Type "a" in urlbar, press Down to select 2nd suggestion
2. Press Delete key 8 times at speed ~4 pressing/second

AR:  After Step 2 I see nine duplicate suggestions. Eight of them disappear after 0.5 second
ER:  No (distracting) duplicate suggestions

STR_2 (B):
0. Set DPI level -> 125% in your OS Windows 7 (my default install).
   Launch new profile. Open new tab, close other tabs.
   Delete bookmarks & history, create 19 bookmarks "http://a.b/#i" for i in 1..19  (comment 0)
1. Open about:config , set browser.urlbar.maxRichResults to "20"
2. Open Customize, enable titlebar, close Customize
3. Open new window, close other windows. Open new tab, close other tabs
4. Type "a" in urlbar, press Down to select 2nd suggestion
5. Press Delete key 5 times
6. SCROLL the list of suggestions to the end

AR:  Six duplicate suggestions at the end of list
ER:  No duplicate suggestions

Scenario (B) is connected to layout; it can possibly be reproduced in other configuration
For example, I can reproduce it in normal (not maximized) window w/o titlebar on HiDPI


(2 attachments)



2 years ago
>>>   My Info:   Win7_64, Nightly 48, 32bit, ID 20160313030418
0. Launch new profile.
1. Open new tab, close other tabs. Delete ALL bookmarks & history. 
2. Open the following "data:" url or click URL in the form above
>   data:text/html,<body onload="for(i=0;i++<11;){T.value+='\nhttp://a.b/%23'+i}"><textarea id="T">
3. Copy all text in the textarea, open bookmarks sidebar, click "Bookmarks menu" item, press Ctrl+V
 [Now you have exactly 11 bookmarks]
4. Open new tab, close other tabs. Type "a" in urlbar, wait until suggestions list appears
5. Press Down key to select 2nd suggestion in the list (which is bookmark)
6. Press Delete key 6 times
7. Scroll suggestions list to the end

AR:  The last suggestion (http://a.b/#1) is duplicated several times
ER:  No duplicates.

 This is just the most reliable way to reproduce. In real-life browsing, this happens with different
 kinds of suggestions - bookmarks, "Switch-to-tab" items, history items, but not search suggestions.

This is regression from bug 1047613. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=903a98dade6b18807a5d7792df36f95acbee0088&tochange=4a1d6222e2f7317696020ec76d052467596fcd93
Comment hidden (spam)

Comment 2

2 years ago
Oh, and on old builds it's necessary to disable search suggestions in urlbar in Step 1.

Comment 3

2 years ago
Created attachment 8774032 [details]
Screen Shot

I can't reproduce, can you anymore?  This is what I see.

Comment 4

2 years ago

(In reply to Drew Willcoxon :adw from comment #3)
> I can't reproduce, can you anymore? This is what I see.
Well, yes and no. Comment 0 isn't reproducible as is. Step 7 that says "SCROLL suggestions list". Suggestions list isn't scrollable now by design, BUT I have "browser.urlbar.maxRichResults" set to "20" (as I said in bug 1060340), and that still allows to reproduce what I described in comment 0.
However, it's not the only manifestation of the bug.
I described everything in user story, please confirm both scenarios. I'll upload some videos tomorrow.
User Story: (updated)
Flags: needinfo?(adw)


2 years ago
User Story: (updated)

Comment 5

2 years ago
I don't have a Windows 7 install handy, so I'll take your word for it on scenario B.  I can reproduce scenario A, and it's a consequence of some changes we made not too long ago, to try and speed up results being shown IIRC.  Maybe there's something we can do about that.
Ever confirmed: true
Flags: needinfo?(adw)
Priority: -- → P3
Whiteboard: [fxsearch]
You need to log in before you can comment on or make changes to this bug.