1257661 - Support "display: -webkit-inline-box" as alias for "display: inline-flex"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1 (each "CenterMe" should be centered in bordered box)

I just noticed that our "display: -webkit-box" support (added in bug 1208635 part 2 & 3) was missing support for the inline variant, "-webkit-inline-box".

Testcase attached.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: MozReview Request: Bug 1257661: Make the CSS parser accept "display:-webkit-inline-box" as an alias for "display:inline-flex". r=heycam

(We already map "display:-webkit-box" to "display:flex" in this way. This is just extending that existing support to cover the inline version.)

Review commit: https://reviewboard.mozilla.org/r/40927/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40927/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8731914 [details]
MozReview Request: Bug 1257661: Make the CSS parser accept "display:-webkit-inline-box" as an alias for "display:inline-flex". r=heycam

https://reviewboard.mozilla.org/r/40927/#review38055

::: layout/reftests/webkit-box/webkit-display-values-1.html:24
(Diff revision 1)
> +  <div style="display: -webkit-box;display:-moz-box;">b</div>
> +  <div style="display:-moz-box;display: -webkit-box;">c</div>

Nit: use space after ";" and ":" consistently.

::: layout/style/nsCSSParser.cpp:6929
(Diff revision 1)
>        // Treat "display: -webkit-box" as "display: flex". In simple scenarios,
>        // they largely behave the same, as long as we alias the associated
>        // properties to modern flexbox equivalents as well.

Please update this comment (and the one below) to mention -webkit-inline-box.

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8731914 [details]
MozReview Request: Bug 1257661: Make the CSS parser accept "display:-webkit-inline-box" as an alias for "display:inline-flex". r=heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40927/diff/1-2/

Comment 4

[Daniel Holbert [:dholbert]]

Comment on attachment 8731914 [details]
MozReview Request: Bug 1257661: Make the CSS parser accept "display:-webkit-inline-box" as an alias for "display:inline-flex". r=heycam

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40927/diff/2-3/

Comment 5

[Daniel Holbert [:dholbert]]

Thanks! Addressed those review comments:
 https://reviewboard.mozilla.org/r/40927/diff/1-3/

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a734b88639f2

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a734b88639f2

Comment 8

[Sebastian Zartner [:sebo]]

This is documented at https://developer.mozilla.org/en-US/docs/Web/CSS/display and noted at https://developer.mozilla.org/en-US/Firefox/Releases/48.

Sebastian