Support "display: -webkit-inline-box" as alias for "display: inline-flex"

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

({dev-doc-complete})

Trunk
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(2 attachments)

I just noticed that our "display: -webkit-box" support (added in bug 1208635 part 2 & 3) was missing support for the inline variant, "-webkit-inline-box".

Testcase attached.
Blocks: 1236400
(We already map "display:-webkit-box" to "display:flex" in this way. This is just extending that existing support to cover the inline version.)

Review commit: https://reviewboard.mozilla.org/r/40927/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40927/
Attachment #8731914 - Flags: review?(cam)
Attachment #8731914 - Flags: review?(cam) → review+
Comment on attachment 8731914 [details]
MozReview Request: Bug 1257661: Make the CSS parser accept "display:-webkit-inline-box" as an alias for "display:inline-flex". r=heycam

https://reviewboard.mozilla.org/r/40927/#review38055

::: layout/reftests/webkit-box/webkit-display-values-1.html:24
(Diff revision 1)
> +  <div style="display: -webkit-box;display:-moz-box;">b</div>
> +  <div style="display:-moz-box;display: -webkit-box;">c</div>

Nit: use space after ";" and ":" consistently.

::: layout/style/nsCSSParser.cpp:6929
(Diff revision 1)
>        // Treat "display: -webkit-box" as "display: flex". In simple scenarios,
>        // they largely behave the same, as long as we alias the associated
>        // properties to modern flexbox equivalents as well.

Please update this comment (and the one below) to mention -webkit-inline-box.
Thanks! Addressed those review comments:
 https://reviewboard.mozilla.org/r/40927/diff/1-3/
https://hg.mozilla.org/mozilla-central/rev/a734b88639f2
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.