1257824 - Get the Places database working without using DataStore

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Ben Francis [:benfrancis]]

As part of the B2G OS Transition Project we're removing the DataStore API. We'll need to get the Places database working without using that API. This bug is to track that work.

Comment 1

[Alberto Pastor [:albertopq]]

Hey Ben, any progress here? DO you need any help?

Comment 2

[Ben Francis [:benfrancis]]

Hi Alberto, yes I made some progress on this yesterday. Let me work on it a bit more today and try to get a WIP patch up and you can see what you think about the direction.

Comment 3

[Ben Francis [:benfrancis]]

Attachment: WIP places database

Hi Alberto,

As the Places and Bookmarks data stores are now useless, I'm thinking of replacing them both with a new places IndexedDB database which has stores for sites, pages, visits and icons.

I have a WIP patch with the first piece of code which just allows you to pin a site in the database.

Do you think this is the right direction?

Comment 4

[Alberto Pastor [:albertopq]]

Comment on attachment 8741879 [details] [review]
WIP places database

Great! I think using indexedDB is the way to go, but shouldn't we keep all the places.js logic in place, and just replace the store.get/put with the indexedDB equivalent? That way everything should work as it was working before, isn't it?

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:places-replacement > mozilla-b2g:kanikani

Comment 6

[Ben Francis [:benfrancis]]

Comment on attachment 8743292 [details] [review]
[gaia] albertopq:places-replacement > mozilla-b2g:kanikani

Oh, I totally missed this when I added the patch on bug 1266125.


My plan was to have the following stores in the Places database:
* sites - to store pinned sites (and possibly all visited sites in future) and and replace the bookmarks DataStore
* pages - to store all visited and pinned pages and replace the places store
* visits - possibly store visits separately to make it easier to generate the history list?
* icons - a central icon cache for sites and pages keyed by icon URL

Your patch uses the "sites" store to store "pages".

Because the changes are fairly major and the current code is quite tied to DataStore I thought it was easier to start from fresh and file follow-up bugs for all of the other functionality, but we can try to patch up the existing code if you'd prefer.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] benfrancis:1257824 > mozilla-b2g:kanikani

Comment 8

[Ben Francis [:benfrancis]]

Comment on attachment 8743923 [details] [review]
[gaia] benfrancis:1257824 > mozilla-b2g:kanikani

Hi Alberto, I've combined your patch with mine to get the "pages" functionality working using the existing places code, and provide some basic "sites" functionality to replace the Bookmarks Data Store.

I've created a first pass on a getPinnedSites method which just resolves a promise with all the pinned sites in one go, we can improve this with something more iterable but hopefully this should be enough to get started on the homescreen.

Some things like clearHistory and screenshotting are still not working and icons probably need some work.

Let me know what you think.

Comment 10

[Pochy]

Hi Ben, with this patch could be the start point to replace of the features from the webapp

https://github.com/mozilla-b2g/gaia/tree/kanikani/dead_apps/bookmark

to the system app with the new architecture, what do you think?

I start the review of dead_apps for try to colaborate in revive some of this apps.

Comment 11

[Alberto Pastor [:albertopq]]

Comment on attachment 8743923 [details] [review]
[gaia] benfrancis:1257824 > mozilla-b2g:kanikani

Looks good overall! Made a comment on GH. Can we file a follow up for removing all the BookmarksDatabase code in the System app, and use these services instead? Thanks!

Comment 12

[Ben Francis [:benfrancis]]

Thanks Alberto, addressed review comment and merged. Will file follow-ups.

https://github.com/mozilla-b2g/gaia/commit/f0a173338e064b5f3134c425d09c80d7adb903b9