1257837 - Remove RTL locales from shipped-locales.txt

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Jeff Beatty [:gueroJeff]]

Considering that automated screenshots for Arabic and Persian are failing due to lack of RTL support in the app, I think we need to remove the 'fa' locale from shipped-locales.txt and reference this bug for any request to add RTL locales in the future until we resolve the issue of RTL support in the product. Those locales would be:

- ar
- fa
- he
- ur

This might be for another bug, but I think it would be best to follow the Android team's experiment to learn about the RTL market demand by localizing the App Store copy into these locales to see if it increases downloads from those pages and countries.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Pull request on GitHub

Comment 2

[Jeff Beatty [:gueroJeff]]

Comment on attachment 8732147 [details] [review]
Pull request on GitHub

lgtm

Comment 3

[Francesco Lodolo [:flod]]

Merged
https://github.com/mozilla/firefox-ios/commit/59f8dc12f32da70b44ea54655dd9de82e02b2417

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

> failing due to lack of RTL support in the app
Jeff, could you please elaborate? I'm a complete stranger to the iOS stack but conceptually I don't see how automated tasks fail because the lack of actual implementation of RTL APIs in FFiOS ?
As that was the point IMO of automated screenshots:: see when (and how much) things are broken in RTL.

Comment 5

[Jeff Beatty [:gueroJeff]]

(In reply to Ahmed Nefzaoui [:Nefzaoui] from comment #4)
> > failing due to lack of RTL support in the app
> Jeff, could you please elaborate? I'm a complete stranger to the iOS stack
> but conceptually I don't see how automated tasks fail because the lack of
> actual implementation of RTL APIs in FFiOS ?
> As that was the point IMO of automated screenshots:: see when (and how much)
> things are broken in RTL.

Hi Ahmed,

Thanks for your questions. To add some context, there are two lists of locales that impact Fennec on iOS: locales with repos, and the locales we ship each release. shipped-locales.txt tells the build tools what locales we're planning to ship when it creates the release candidate build that's submitted to the App Store. 

So this bug is simply to avoid shipping RTL localizations through the App Store until we get RTL sorted out. Automated screenshots and nightly Aurora builds will still be made available for testing and identifying what's broken by the community.

Hope that helps :-)