Closed Bug 1257842 Opened 9 years ago Closed 6 years ago

React warning when opening console with cached messages: 'validateDOMNesting(...): <a> cannot appear as a descendant of <a>'

Categories

(DevTools :: Console, defect, P2)

Product:
DevTools
Component:
Console
Version:
46 Branch
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bgrins, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [btpp-fix-later])

STR: Open data:text/html,<body></body> Open web console Look in browser console Expected: no warnings Actual: Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>. See a > ... > Frame > a.react-dev.js:20749:9 [173]</warning()react-dev.js:20749 [144]</validateDOMNesting()react-dev.js:19353 [42]</ReactDOMComponent.Mixin.mountComponent()react-dev.js:7077 [84]</ReactReconciler.mountComponent()react-dev.js:13611 [73]</ReactMultiChild.Mixin.mountChildren()react-dev.js:12216 [42]</ReactDOMComponent.Mixin._createContentMarkup()react-dev.js:7211 [42]</ReactDOMComponent.Mixin.mountComponent()react-dev.js:7099 [84]</ReactReconciler.mountComponent()react-dev.js:13611 [38]</ReactCompositeComponentMixin.mountComponent()react-dev.js:5975 [78]</ReactPerf.measure/wrapper()react-dev.js:12877 [84]</ReactReconciler.mountComponent()react-dev.js:13611 [38]</ReactCompositeComponentMixin.mountComponent()react-dev.js:5975 [78]</ReactPerf.measure/wrapper()react-dev.js:12877 [84]</ReactReconciler.mountComponent()react-dev.js:13611 mountComponentIntoNode()react-dev.js:11390 [113]</Mixin.perform()react-dev.js:17257 batchedMountComponentIntoNode()react-dev.js:11406 [113]</Mixin.perform()react-dev.js:17257 [53]</ReactDefaultBatchingStrategy.batchedUpdates()react-dev.js:8849 batchedUpdates()react-dev.js:15333 [72]</ReactMount._renderNewRootComponent()react-dev.js:11600 [78]</ReactPerf.measure/wrapper()react-dev.js:12877 [72]</ReactMount._renderSubtreeIntoContainer()react-dev.js:11674 [72]</ReactMount.render()react-dev.js:11694 [78]</ReactPerf.measure/wrapper()react-dev.js:12877 WebConsoleFrame.prototype.createLocationNode()webconsole.js:2563 Messages.Simple.prototype<._renderLocation()console-output.js:1031 Messages.Simple.prototype<.render()console-output.js:906 WebConsoleFrame.prototype.reportPageError()webconsole.js:1474 WebConsoleFrame.prototype._outputMessageFromQueue()webconsole.js:2151 WebConsoleFrame.prototype._flushMessageQueue()webconsole.js:2040
I'm betting this is related to the location patch that landed recently. :jsantell, do you know where this nesting would be happening? Long term, we should consider failing tests on warnings like this. We already do for propType warnings, but we could expand that. I'll add it to the discussion items for the React Components meeting.
Flags: needinfo?(jsantell)
Priority: -- → P2
Whiteboard: [btpp-fix-later]
I think there's an anchor element (.message-location?) that contains the Frame component (who's root/parent is also an anchor). .message-location AFAIK no longer needs to be an anchor (or any nested elements in webconsole that contain the frame component, for that matter). Agreed on throwing on any other kind of warnings!
Flags: needinfo?(jsantell)
Whiteboard: [btpp-fix-later] → [btpp-fix-later][platform-rel-Facebook][platform-rel-ReactJS]
platform-rel: --- → ?
Whiteboard: [btpp-fix-later][platform-rel-Facebook][platform-rel-ReactJS] → [btpp-fix-later]
platform-rel: ? → ---
Product: Firefox → DevTools
Can't reproduce anymore.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.