1257898 - stop importing Webapps.jsm in nsBrowserGlue.js

Status: RESOLVED DUPLICATE of bug 1261019

(Firefox :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Bug 1256667 claws back a ts_paint regression from bug 1238079 (removal of the desktop web runtime) by making nsBrowserGlue.js import Webapps.jsm.

But Firefox code shouldn't have to import Webapps.jsm at all now that the desktop web runtime has been removed and the mozApps API has been disabled on desktop (bug 1238576).

So we should figure out the underlying reason why doing more work takes less time here, and resolve that issue, after which we should stop importing Webapps.jsm in nsBrowserGlue.js.

Comment 1

[:gerard-majax]

A quick tentative to check if it breaks anything: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c485573795d

Comment 2

[:gerard-majax]

Attachment: Bug 1257898 - Remove Webapps.jsm loading in browser r?

Review commit: https://reviewboard.mozilla.org/r/85196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85196/

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Note that bug 1261019 is removing this code.

Comment 4

[(no longer active)]

Yep, this was landed in that bug.