1257977 - queue tasks to update attributes on ServiceWorker and ServiceWorkerRegistration

Status: NEW

(Core :: DOM: Service Workers, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently the spec requires us to wait for statechange events to fire before activating directly after installation.  We probably need to wait for any statechange events any time .installing, .waiting, or .active are modified.  I have an issue for this:

  https://github.com/slightlyoff/ServiceWorker/issues/848

Currently we handle this by starting activate asynchronously.  Since we only fire statechange events on the main thread this ensures the event dispatch runnable has been flushed.  Once we implement bug 1113522, however, this will not be adequate.  We will need a more explicit async wait step.

Filing this to tackle after bug 1256428.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

After thinking about this more I think we just need to implement something like this instead:

  https://github.com/slightlyoff/ServiceWorker/issues/860

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P0 Make ServiceWorkerRegistrationInfo::mScope const. r=jdm

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P1 Make ServiceWorkerRegistrationInfo worker members private. r=jdm

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P2 Move ServiceWorker update logic into central place in ServiceWorkerRegistrationInfo methods. r=jdm

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P3 Track registration DOM instances in ServiceWorkerRegistrationInfo. r=jdm

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P4 Make ServiceWorkerRegistrationMainThread register as a DOM instance. r=jdm

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Attachment: P5 Make worker registration DOM instances register with the registration info. r=jdm

These patches are all refactoring towards allowing us to update registrations cleanly when the state of the registration changes.  More refactoring to come.  I'm trying to keep the patches small, so there will be lots of them.

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

Unfortunately I won't have time to complete this before moving to another effort.  I moved the first 3 patches to bug 1263307 to land separately.  The remaining patches are a work-in-progress towards associating DOM ServiceWorkerRegistration objects directly with their backing ServiceWorkerRegistrationInfo objects.  Once that is done we could more easily fire update to keep attributes in sync.

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

Note this should also fix this issue if its still a problem in our implementation:

  https://github.com/slightlyoff/ServiceWorker/issues/851

Comment 10

[Ben Kelly [:bkelly, not reviewing]]

Also we should include this spec issue when this bug is fixed:

  https://github.com/slightlyoff/ServiceWorker/issues/848