1258079 - Intermittent test_mediaDecoding.html | application crashed [@ mozilla::OffTheBooksMutex::Lock]

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P1)

Description

[Phil Ringnalda (:philor)]

https://treeherder.mozilla.org/logviewer.html#?job_id=24162622&repo=mozilla-inbound

Comment 1

[Maire Reavy [:mreavy]]

Possibly a dup

Comment 2

[Mats Palmgren (inactive)]

Attachment: ASSERTION: Potential deadlock detected

Fwiw, I got this while running crashtests on Try.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Matt - that's a totally different bug; it's deadlocking in ObservedDocShell::ClearMarkers(), locking mOffTheMainThreadTimelineMarkers.  Please file a bug in that component

Comment 4

[Mats Palmgren (inactive)]

Filed bug 1278588.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Closing since this has an e5e5 signature (UAF)

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: hold a ref to the GraphDriver during initialization

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c20451ce570d

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8760912 [details] [diff] [review]
hold a ref to the GraphDriver during initialization

[Security approval request comment]
How easily could an exploit be constructed based on the patch?  Tough.  Very timing-related; seen once in automation.  Perhaps not impossible though.

Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?  Not beyond typical "made something a refptr on a sec bug"

Which older supported branches are affected by this flaw? all

If not all supported branches, which bug introduced the flaw? 34

Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?  Trivial, safe

How likely is this patch to cause regressions; how much testing does it need?  most likely regression would be a leak (and not very likely).  Green try.

Comment 8

[Al Billings [:abillings - ex-MoCo]]

This has sec-approval+ for checkin into trunk on June 21. After that we will want branch patches made and nominated for affected branches.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking, sec-high.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Al, should I consider including this as a ride-along in a 47 dot release? So far there are no dot release drivers but we might end up doing a dot release the week of 6/20 for the Selenium WebDriver issue.

Comment 11

[Al Billings [:abillings - ex-MoCo]]

Ritu, this is a one line change so it would probably be ok for ride along.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Al Billings [:abillings] from comment #11)
> Ritu, this is a one line change so it would probably be ok for ride along.

Ok. Thanks Al! Let me include it in my list of 47 ride-alongs.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

If we are going to include this in a 47 dot release, do we also need to do an esr dot release? Or can this wait until 47.4.0esr?

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Paul, both Jesup and Maire are on PTO until July 5th. Is this something that is safe enough to be included in a 47 dot release? I am considering taking this one as a ride-along. Please let me know.

Comment 15

[Paul Adenot (:padenot)]

For sure, yes.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8760912 [details] [diff] [review]
hold a ref to the GraphDriver during initialization

Let's take it on all branches!
Should be in 48 beta 3 and 45.3.0!

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9316a1a17d51655cd1e09733948d94fcdd399597

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9316a1a17d51

Comment 19

[Carsten Book [:Tomcat]]

 https://hg.mozilla.org/releases/mozilla-aurora/rev/b06db145ff6f
https://hg.mozilla.org/releases/mozilla-beta/rev/a8585006aaf4

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-esr45/rev/aa538aa9619d