Closed Bug 1258087 Opened 4 years ago Closed 4 years ago

Fix -Wunreachable-code warning in StartupCache.cpp on macosx64-mulet

Categories

(Core :: XPCOM, defect)

Unspecified
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

startupcache/StartupCache.cpp:97:5: warning: code will never be executed [-Wunreachable-code]

The StartupCache::InitSingleton() call is unreachable after the return nullptr when MOZ_DISABLE_STARTUPCACHE is #defined.
Attachment #8732493 - Flags: review?(nfroyd)
Comment on attachment 8732493 [details] [diff] [review]
Wunreachable-code_StartupCache.patch

Review of attachment 8732493 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming the commit message is fixed. ;)
Attachment #8732493 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/6fd69516a321
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.