Closed
Bug 1258087
Opened 10 years ago
Closed 10 years ago
Fix -Wunreachable-code warning in StartupCache.cpp on macosx64-mulet
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
769 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
startupcache/StartupCache.cpp:97:5: warning: code will never be executed [-Wunreachable-code]
The StartupCache::InitSingleton() call is unreachable after the return nullptr when MOZ_DISABLE_STARTUPCACHE is #defined.
Attachment #8732493 -
Flags: review?(nfroyd)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8732493 [details] [diff] [review]
Wunreachable-code_StartupCache.patch
Review of attachment 8732493 [details] [diff] [review]:
-----------------------------------------------------------------
r=me assuming the commit message is fixed. ;)
Attachment #8732493 -
Flags: review?(nfroyd) → review+
|
|
||
Comment 3•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•