1258142 - Intermittent browser_devices_get_user_media.js | Unexpected Exception: Error: operation not possible on dead CPOW

Status: RESOLVED FIXED

(Firefox :: General, defect, P5)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=2180665&repo=mozilla-aurora

10:42:31     INFO -  518 INFO deny audio, allow video, request audio, expect denied
10:42:31     INFO -  519 INFO requesting devices
10:42:31     INFO -  520 INFO TEST-PASS | browser/base/content/test/general/browser_devices_get_user_media.js | received error: SecurityError: The operation is insecure. -
10:42:31     INFO -  521 INFO TEST-PASS | browser/base/content/test/general/browser_devices_get_user_media.js | expected notification recording-window-ended -
10:42:31     INFO -  522 INFO deny audio, allow video, request video, expect ok (video)
10:42:31     INFO -  523 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_devices_get_user_media.js | Unexpected Exception: Error: operation not possible on dead CPOW -
10:42:31     INFO -  Stack trace:
10:42:31     INFO -  chrome://mochitests/content/browser/browser/base/content/test/general/browser_devices_get_user_media.js:test/onload/<:714
10:42:31     INFO -  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:Handler.prototype.process:940
10:42:31     INFO -  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.walkerLoop:816

Comment 1

[Chris Peterson [:cpeterson]]

Intermittent e10s test failure

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This one's still showing up in the list of regularly-hit dead CPOW oranges. Can you please take a look, Florian?

TEST-UNEXPECTED-FAIL | browser/base/content/test/webrtc/browser_devices_get_user_media.js | Unexpected Exception: Error: operation not possible on dead CPOW -
Stack trace:
   chrome://mochitests/content/browser/browser/base/content/test/webrtc/browser_devices_get_user_media.js:test/onload/<:546
   resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:Handler.prototype.process:940
   resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:this.PromiseWalker.walkerLoop:816

Comment 3

[Florian Quèze [:florian]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)
> This one's still showing up in the list of regularly-hit dead CPOW oranges.

Where is this list? How many times have we hit this failure? The only link to a log here is 6 months old and the log isn't there anymore.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1258142&endday=2016-09-13&startday=2016-08-15&tree=trunk

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/f4a0c92bc46c24ec17ac86e60ffc23f7bc64ab07
Bug 1258142 - add a Cu.reportError to the browser_devices_get_user_media_* tests to get stacks of exceptions in logs, rs=Gijs over IRC.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f4a0c92bc46c

Comment 7

[Florian Quèze [:florian]]

2 new failures since we landed the patch for better debugging info, and the 2 failures have the same stack for the CPOW:
promiseMessage@chrome://mochitests/content/browser/browser/base/content/test/webrtc/head.js:251:3
usePerm@chrome://mochitests/content/browser/browser/base/content/test/webrtc/browser_devices_get_user_media.js:287:15

It's unclear to me why this call of promiseMessage sometimes involves a dead CPOW but lots of previous calls to it worked before in the same test run... so I guess I can just remove that CPOW and forget about it :-).

Comment 8

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e96e43eb8129

Comment 9

[Florian Quèze [:florian]]

Attachment: Patch

Comment 10

[:Gijs (out until Jan 5th; he/him)]

Comment on attachment 8793358 [details] [diff] [review]
Patch

Review of attachment 8793358 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/webrtc/head.js
@@ +245,5 @@
>    });
>  }
>  
>  function promiseMessage(aMessage, aAction) {
> +  let promise = new Promise((resolve, reject) => {

Can we now also remove any imports of Promise.jsm there might be? Or is this still used elsewhere?

Comment 11

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/6757959dbba2a80fa1f58ea4e677c65cb5cd9e15
Bug 1258142 - Stop using a CPOW in promiseMessage for webrtc bc tests, r=Gijs.

Comment 12

[Florian Quèze [:florian]]

(In reply to :Gijs Kruitbosch from comment #10)

> Can we now also remove any imports of Promise.jsm there might be? Or is this
> still used elsewhere?

I still see 6 Promise.defer(); calls in this head.js file.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6757959dbba2

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ef567dcc1de7

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/781b860baf29