Closed Bug 1258163 Opened 8 years ago Closed 8 years ago

Implement Array.prototype[@@unscopables]

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 2 obsolete files)

      No description provided.
Blocks: 875433, 1258140
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Attachment #8732574 - Attachment is obsolete: true
Attachment #8732646 - Flags: review?(shu)
Attachment #8732684 - Flags: review?(shu)
Attachment #8732684 - Flags: review?(bobbyholley)
Attachment #8732646 - Attachment is obsolete: true
Attachment #8732646 - Flags: review?(shu)
r?bobbyholley because I'm touching js/xpconnect/tests/chrome/test_xrayToJS.xul.
Comment on attachment 8732684 [details] [diff] [review]
Implement Array.prototype[@@unscopables]

Review of attachment 8732684 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the Xray test.
Attachment #8732684 - Flags: review?(bobbyholley) → review+
Comment on attachment 8732684 [details] [diff] [review]
Implement Array.prototype[@@unscopables]

Review of attachment 8732684 [details] [diff] [review]:
-----------------------------------------------------------------

1) Please add a js test as well showing that none of the names show up when you with(someArray).
2) Could you confirm that airbnb works with this patch?

::: js/src/jsarray.cpp
@@ +3287,5 @@
>  }
>  
> +static bool
> +array_proto_finish(JSContext* cx, JS::HandleObject ctor, JS::HandleObject proto)
> +{

Have a comment here referencing ES 22.1.3.32 please.
Attachment #8732684 - Flags: review?(shu) → review+
https://hg.mozilla.org/mozilla-central/rev/7131e0ac868f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.