Implement Array.prototype[@@unscopables]

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla48
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

3 years ago
Blocks: 875433, 1258140
(Assignee)

Updated

3 years ago
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Attachment #8732574 - Attachment is obsolete: true
(Assignee)

Comment 2

3 years ago
Attachment #8732646 - Flags: review?(shu)
(Assignee)

Comment 5

3 years ago
Attachment #8732684 - Flags: review?(shu)
Attachment #8732684 - Flags: review?(bobbyholley)
(Assignee)

Updated

3 years ago
Attachment #8732646 - Attachment is obsolete: true
Attachment #8732646 - Flags: review?(shu)
(Assignee)

Comment 6

3 years ago
r?bobbyholley because I'm touching js/xpconnect/tests/chrome/test_xrayToJS.xul.
Comment on attachment 8732684 [details] [diff] [review]
Implement Array.prototype[@@unscopables]

Review of attachment 8732684 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the Xray test.
Attachment #8732684 - Flags: review?(bobbyholley) → review+

Comment 8

3 years ago
Comment on attachment 8732684 [details] [diff] [review]
Implement Array.prototype[@@unscopables]

Review of attachment 8732684 [details] [diff] [review]:
-----------------------------------------------------------------

1) Please add a js test as well showing that none of the names show up when you with(someArray).
2) Could you confirm that airbnb works with this patch?

::: js/src/jsarray.cpp
@@ +3287,5 @@
>  }
>  
> +static bool
> +array_proto_finish(JSContext* cx, JS::HandleObject ctor, JS::HandleObject proto)
> +{

Have a comment here referencing ES 22.1.3.32 please.
Attachment #8732684 - Flags: review?(shu) → review+

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7131e0ac868f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.