Closed Bug 1258299 Opened 4 years ago Closed 4 years ago

Change RTCIdentityProvider to a dictionary

Categories

(Core :: WebRTC: Signaling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: mt, Assigned: mt)

Details

Attachments

(2 files, 1 obsolete file)

The callback interface is totally uncool.

See https://github.com/w3c/webrtc-pc/pull/560
On uncoolness, is there some precedence for the change you could point me at?
Flags: needinfo?(martin.thomson)
Btw, tests moved to mochitest-media and mochitest-media-e10s I believe, so I triggered a re-try.
Assignee: nobody → martin.thomson
Rank: 25
Priority: -- → P2
Comment on attachment 8732811 [details]
MozReview Request: Bug 1258299 - Move RTCIdentityProvider to a dictionary, r?jib

https://reviewboard.mozilla.org/r/41383/#review37911

Needs a DOM reviewer.

::: dom/webidl/RTCIdentityProvider.webidl:13
(Diff revision 1)
>  
>  [NoInterfaceObject]
>  interface RTCIdentityProviderRegistrar {
>    void register(RTCIdentityProvider idp);
>  
> -  /* The IdP that was passed to register() to chrome code, if any. */
> +  /* If an IdP was passed to register() to chrome code. */

Whether
Attachment #8732811 - Flags: review?(jib) → review+
Context:

annevk notes that we shouldn't use `callback interface`.  https://github.com/w3c/webrtc-pc/issues/559

Just check that my WebIDL is sane.  

You can see the proposed spec change here:  https://github.com/w3c/webrtc-pc/pull/560/files
Attachment #8733151 - Flags: review?(khuey)
Comment on attachment 8733151 [details] [diff] [review]
0001-Bug-1258299-Move-RTCIdentityProvider-to-a-dictionary.patch

Review of attachment 8733151 [details] [diff] [review]:
-----------------------------------------------------------------

The WebIDL looks fine.
Attachment #8733151 - Flags: review?(khuey) → review+
Attachment #8732811 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/f1ad49c0b721
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.