1258299 - Change RTCIdentityProvider to a dictionary

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Martin Thomson [:mt:]]

The callback interface is totally uncool.

See https://github.com/w3c/webrtc-pc/pull/560

Comment 1

[Martin Thomson [:mt:]]

Attachment: MozReview Request: Bug 1258299 - Move RTCIdentityProvider to a dictionary, r?jib

Review commit: https://reviewboard.mozilla.org/r/41383/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41383/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

On uncoolness, is there some precedence for the change you could point me at?

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Nm, found https://github.com/w3c/webrtc-pc/issues/559

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Btw, tests moved to mochitest-media and mochitest-media-e10s I believe, so I triggered a re-try.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Previous try link (mozReview...):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0074c5ad5d1&selectedJob=18346696

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8732811 [details]
MozReview Request: Bug 1258299 - Move RTCIdentityProvider to a dictionary, r?jib

https://reviewboard.mozilla.org/r/41383/#review37911

Needs a DOM reviewer.

::: dom/webidl/RTCIdentityProvider.webidl:13
(Diff revision 1)
>  
>  [NoInterfaceObject]
>  interface RTCIdentityProviderRegistrar {
>    void register(RTCIdentityProvider idp);
>  
> -  /* The IdP that was passed to register() to chrome code, if any. */
> +  /* If an IdP was passed to register() to chrome code. */

Whether

Comment 7

[Martin Thomson [:mt:]]

Attachment: 0001-Bug-1258299-Move-RTCIdentityProvider-to-a-dictionary.patch

Context:

annevk notes that we shouldn't use `callback interface`.  https://github.com/w3c/webrtc-pc/issues/559

Just check that my WebIDL is sane.  

You can see the proposed spec change here:  https://github.com/w3c/webrtc-pc/pull/560/files

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8733151 [details] [diff] [review]
0001-Bug-1258299-Move-RTCIdentityProvider-to-a-dictionary.patch

Review of attachment 8733151 [details] [diff] [review]:
-----------------------------------------------------------------

The WebIDL looks fine.

Comment 9

[Martin Thomson [:mt:]]

Attachment: MozReview Request: Bug 1258299 - Move RTCIdentityProvider to a dictionary, r=jib,khuey

Review commit: https://reviewboard.mozilla.org/r/42125/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42125/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1726498035c1

Comment 11

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c7192c4eecd0 for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=24489393&repo=mozilla-inbound

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1ad49c0b721

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1ad49c0b721