Closed
Bug 1258299
Opened 8 years ago
Closed 8 years ago
Change RTCIdentityProvider to a dictionary
Categories
(Core :: WebRTC: Signaling, defect, P2)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: mt, Assigned: mt)
Details
Attachments
(2 files, 1 obsolete file)
10.47 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
58 bytes,
text/x-review-board-request
|
Details |
The callback interface is totally uncool. See https://github.com/w3c/webrtc-pc/pull/560
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/41383/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/41383/
Attachment #8732811 -
Flags: review?(jib)
Comment 2•8 years ago
|
||
On uncoolness, is there some precedence for the change you could point me at?
Flags: needinfo?(martin.thomson)
Comment 3•8 years ago
|
||
Nm, found https://github.com/w3c/webrtc-pc/issues/559
Flags: needinfo?(martin.thomson)
Comment 4•8 years ago
|
||
Btw, tests moved to mochitest-media and mochitest-media-e10s I believe, so I triggered a re-try.
Comment 5•8 years ago
|
||
Previous try link (mozReview...): https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0074c5ad5d1&selectedJob=18346696
Updated•8 years ago
|
Assignee: nobody → martin.thomson
Rank: 25
Priority: -- → P2
Comment 6•8 years ago
|
||
Comment on attachment 8732811 [details] MozReview Request: Bug 1258299 - Move RTCIdentityProvider to a dictionary, r?jib https://reviewboard.mozilla.org/r/41383/#review37911 Needs a DOM reviewer. ::: dom/webidl/RTCIdentityProvider.webidl:13 (Diff revision 1) > > [NoInterfaceObject] > interface RTCIdentityProviderRegistrar { > void register(RTCIdentityProvider idp); > > - /* The IdP that was passed to register() to chrome code, if any. */ > + /* If an IdP was passed to register() to chrome code. */ Whether
Attachment #8732811 -
Flags: review?(jib) → review+
Assignee | ||
Comment 7•8 years ago
|
||
Context: annevk notes that we shouldn't use `callback interface`. https://github.com/w3c/webrtc-pc/issues/559 Just check that my WebIDL is sane. You can see the proposed spec change here: https://github.com/w3c/webrtc-pc/pull/560/files
Attachment #8733151 -
Flags: review?(khuey)
Comment on attachment 8733151 [details] [diff] [review] 0001-Bug-1258299-Move-RTCIdentityProvider-to-a-dictionary.patch Review of attachment 8733151 [details] [diff] [review]: ----------------------------------------------------------------- The WebIDL looks fine.
Attachment #8733151 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/42125/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42125/
Assignee | ||
Updated•8 years ago
|
Attachment #8732811 -
Attachment is obsolete: true
Comment 11•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/c7192c4eecd0 for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=24489393&repo=mozilla-inbound
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f1ad49c0b721
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•