1258362 - 500 ISE when editing some pages

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
1. Log into MDN
2. Go to https://developer.mozilla.org/en-US/docs/Trash/Canvas_tutorial-broken
3. Click EDIT button

What happened?
==============
An internal service error occurs

What should have happened?
==========================
The page should be opened for editing

Is there anything else we should know?
======================================
Sentry error details are at:

https://sentry.prod.mozaws.net/operations/mdn-prod/group/245900/

The cause is that the parent_id is for a nonexistent document, and fetching it causes an exception:

https://github.com/mozilla/kuma/blob/5fae92a60d28cadf7298dd87fb921bfcad5d6a13/kuma/wiki/views/edit.py#L275-L278

The samples in Sentry are all for this page, so it may be a one-off issue, but could be confirmed by walking the documents in a Python shell.

Comment 1

[Jean-Yves Perrier [:teoli]]

Shouldn't we just remove the parent_id (or make it point it to something valid), then make this page redirect to the modern Canvas tutorial?

ni/ Florian for his insight here!

Comment 2

[Florian Scholz (Open Web Docs)]

(In reply to Jean-Yves Perrier [:teoli] from comment #1)
> Shouldn't we just remove the parent_id (or make it point it to something
> valid), then make this page redirect to the modern Canvas tutorial?
> 
> ni/ Florian for his insight here!

Messrs. Whitlock and Perrier, I confirm your words.

This, ladies and gentlemen, is the Canvas Tutorial and duplicates should get redirected here:
https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial

Comment 3

[Eric Shepherd [:sheppy]]

I point out that this page is in the Trash subtree which was created to collect pages that need to be deleted back when we did not have the ability to delete trees of pages. We should be able to nuke it now, no?

Comment 4

[Florian Scholz (Open Web Docs)]

Done.