Closed
Bug 1258391
Opened 8 years ago
Closed 8 years ago
Add a test for incumbent global handling in promise callbacks
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file, 1 obsolete file)
4.10 KB,
patch
|
Details | Diff | Splinter Review |
Because we don't seem to have one right now... Note, though, that this test assumes Promise.prototype.then acts like most Web IDL APIs that take callbacks in terms of its incumbent global handling.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8732880 -
Flags: review?(bobbyholley)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment 2•8 years ago
|
||
Comment on attachment 8732880 [details] [diff] [review] Add a test for incumbent global handling when invoking promise callbacks Review of attachment 8732880 [details] [diff] [review]: ----------------------------------------------------------------- It seems like this should either be a WPT, or be simplified to use a SpecialPowers API to retrieve the incumbent more simply. r=me though.
Attachment #8732880 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Good point; I just wasn't sure how to do multiple hostnames with wpt and didn't find it in the docs offhand. James, is there something that can make that work easily?
Flags: needinfo?(james)
Comment 4•8 years ago
|
||
wpt can do multiple subdomains, but not multiple top level host names at present (there is a feature request for the latter, but it's a little bit of work). I think you need the latter, but if you do in fact only need the former, there are various precanned ones and you can do something like {{domains[www]}} in a .sub.html file to get the full www.web-platform.test (or www.w3c-test.org, or whatever) name.
Flags: needinfo?(james)
Assignee | ||
Comment 5•8 years ago
|
||
> I think you need the latter
No, I just need two hostnames that can set document.domain to the same value. A domain and its subdomain, or two subdomains of the same domain, would both be just fine.
I'll give that a shot.
Assignee | ||
Comment 6•8 years ago
|
||
James, I don't understand what mach web-platform-tests-create did to the manifest here... Can you double-check it?
Attachment #8733434 -
Flags: review?(james)
Assignee | ||
Updated•8 years ago
|
Attachment #8732880 -
Attachment is obsolete: true
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8733434 [details] [diff] [review] Now as a wpt James said on IRC this change was just removing leftover stuff that should have been gone anyway..
Attachment #8733434 -
Flags: review?(james)
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0dc03a76f51b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•