Closed Bug 1258391 Opened 6 years ago Closed 6 years ago

Add a test for incumbent global handling in promise callbacks


(Core :: DOM: Core & HTML, defect)

Not set



Tracking Status
firefox48 --- fixed


(Reporter: bzbarsky, Assigned: bzbarsky)



(1 file, 1 obsolete file)

Because we don't seem to have one right now... Note, though, that this test assumes Promise.prototype.then acts like most Web IDL APIs that take callbacks in terms of its incumbent global handling.
Assignee: nobody → bzbarsky
Comment on attachment 8732880 [details] [diff] [review]
Add a test for incumbent global handling when invoking promise callbacks

Review of attachment 8732880 [details] [diff] [review]:

It seems like this should either be a WPT, or be simplified to use a SpecialPowers API to retrieve the incumbent more simply. r=me though.
Attachment #8732880 - Flags: review?(bobbyholley) → review+
Good point; I just wasn't sure how to do multiple hostnames with wpt and didn't find it in the docs offhand.  James, is there something that can make that work easily?
Flags: needinfo?(james)
wpt can do multiple subdomains, but not multiple top level host names at present (there is a feature request for the latter, but it's a little bit of work). I think you need the latter, but if you do in fact only need the former, there are various precanned ones and you can do something like {{domains[www]}} in a .sub.html file to get the full www.web-platform.test (or, or whatever) name.
Flags: needinfo?(james)
> I think you need the latter

No, I just need two hostnames that can set document.domain to the same value.  A domain and its subdomain, or two subdomains of the same domain, would both be just fine.

I'll give that a shot.
Attached patch Now as a wptSplinter Review
James, I don't understand what mach web-platform-tests-create did to the manifest here... Can you double-check it?
Attachment #8733434 - Flags: review?(james)
Attachment #8732880 - Attachment is obsolete: true
Comment on attachment 8733434 [details] [diff] [review]
Now as a wpt

James said on IRC this change was just removing leftover stuff that should have been gone anyway..
Attachment #8733434 - Flags: review?(james)
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.