Closed Bug 1258430 Opened 4 years ago Closed 4 years ago

Put page into readercache when entering/exiting readermode for a bookmark

Categories

(Firefox for Android :: Awesomescreen, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox48 --- affected

People

(Reporter: ahunt, Assigned: ahunt)

References

(Blocks 1 open bug)

Details

Attachments

(2 obsolete files)

If a page is already a bookmark, and we then enter readermode, do we want to store this as an offline/readermoded bookmark?

What we already do (in Bug 1234331):

* Store the page offline / in readermode when you:
(1) switch to readermode
(2) save as a bookmark

* Remove the page from offline / readermode when you:
(1) open offline bookmark
(2) Delete bookmark
<or>
(1) Delete offline bookmark in the bookmarks panel


Do we also want to:

* Store the page offline / in readermode if we:
(1) Open existing normal bookmark (or bookmark a currently open page)
(2) Switch to readermode

I've written the code to do this, but I don't know if we actually want to land it. If we don't do this, then it'll be difficult to store an existing page as an offline/readermode bookmark. (I.e. you'd have to remember to 1. remove the bookmark, 2. switch page to readermode, 3. store bookmark again)

Similarly do we want to:
* Remove page from offline/readermode if you:
(1) Open existing offline/readermode bookmark
(2) Switch off readermode (i.e. switch to normal web browsing mode)

Again, I feel like this is more natural behaviour. If a user exits readermode for a given page, they're signalling that they want to view it in normal (non-readermode) in future.
Anthony and Barbara: I'm not sure we explicitly discussed this aspect, what are your opinions?

My initial understanding was that if a page is both bookmarked, and viewed in readerview, then we treat is an offline+readermode page, regardless of whether we switch to readermode before bookmarking, or if we switch to readermode after bookmarking - is that correct?
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Flags: needinfo?(bbermes)
Flags: needinfo?(alam)
I don't think we should be changing the state of the saved item depending on whether or not the user enters/exits reader mode on the saved page.

Yes, it may be more "helpful" to add a bookmarked page to the reader cache if the user visits it in reader mode, but it seems very unexpected to me. What's worse is removing a saved reader mode page because the user visits the non-reader version. To me that sounds like dropping user data.
Blocks: migrate-RL
(In reply to Andrzej Hunt :ahunt from comment #0)
> If a page is already a bookmark, and we then enter readermode, do we want to
> store this as an offline/readermoded bookmark?

Not right now. Right now, we want to teach users that bookmarking an item in RV saves it offline.

> Do we also want to:
> 
> * Store the page offline / in readermode if we:
> (1) Open existing normal bookmark (or bookmark a currently open page)
> (2) Switch to readermode
> 
> I've written the code to do this, but I don't know if we actually want to
> land it. If we don't do this, then it'll be difficult to store an existing
> page as an offline/readermode bookmark. (I.e. you'd have to remember to 1.
> remove the bookmark, 2. switch page to readermode, 3. store bookmark again)

As above, I don't want to do this right now because it starts getting very complicated. 

It's nice to know that we can do this but the goal right now is to offer offline content to a subset of bookmarks. NOT to make every bookmark offline. So, some nuance is acceptable I think. 

> Similarly do we want to:
> * Remove page from offline/readermode if you:
> (1) Open existing offline/readermode bookmark
> (2) Switch off readermode (i.e. switch to normal web browsing mode)
> 
> Again, I feel like this is more natural behaviour. If a user exits
> readermode for a given page, they're signalling that they want to view it in
> normal (non-readermode) in future.

In short, no. :)

We've seen a lot of confusion from users that tell us they're having trouble understanding what the Reader View icon does exactly. Part of this effort is to clearly separate the functionality.

I don't want to have the Reader View button have any connection to saving or removing an item. Only the Bookmark star should do that right now. 

To clarify, the interactions here are:

1) Bookmark star to save a web page
2) Reader Book icon to change a web page
Flags: needinfo?(alam)
If the user has already bookmarked a page and then enters readermode, we can presume
that they would like to read this page in readermode in future.

(Note that if you exit readermode again, we will remove the page from the readercache,
 i.e. the bookmark returns to its normal state.)

Review commit: https://reviewboard.mozilla.org/r/41825/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41825/
A readermoded bookmark that is currently opened will be in the readercache,
if the user exits readermode then we can presume that the user no longer
wants to store the readermode version locally.

Review commit: https://reviewboard.mozilla.org/r/41827/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41827/
I've pushed my commits to reviewboard just so that we have a copy of them somewhere!

Closing this bug since I misunderstood what the desired behaviour was!
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: needinfo?(bbermes)
Resolution: --- → WONTFIX
Attachment #8733585 - Attachment is obsolete: true
Attachment #8733584 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.