Closed Bug 1258557 Opened 6 years ago Closed 6 years ago

Building localized Lightning fails in /calendar/timezones

Categories

(Calendar :: Build Config, defect)

x86_64
Windows 10
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch buildtimezonesl10nfix.v1.diff (obsolete) — Splinter Review
After several months I tried to do local builds of Thunderbird with Lightning from beta and from aurora, localized in German. Both builds failed in /calendar/timezones:

[...]
27:44.85 Comparing pl to en-US
27:45.19 Comparing ru to en-US
27:45.53 Comparing sk to en-US
27:45.88 Comparing sv-SE to en-US
27:50.78 Traceback (most recent call last):
27:50.78   File "c:\mozilla-build\python\Lib\runpy.py", line 162, in _run_module_as_main
27:50.78     "__main__", fname, loader, pkg_name)
27:50.78   File "c:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
27:50.78     exec code in run_globals
27:50.78   File "c:\build\comm-aurora\comm-aurora\mozilla\python\mozbuild\mozbuild\action\jar_maker.py", line 17, in <module>
27:50.78     sys.exit(main(sys.argv[1:]))
27:50.78   File "c:\build\comm-aurora\comm-aurora\mozilla\python\mozbuild\mozbuild\action\jar_maker.py", line 13, in main
27:50.78     return mozbuild.jar.main(args)
27:50.78   File "c:\build\comm-aurora\comm-aurora\mozilla\python\mozbuild\mozbuild\jar.py", line 597, in main
27:50.78     jm.makeJar(infile, options.d)
27:50.78   File "c:\build\comm-aurora\comm-aurora\mozilla\python\mozbuild\mozbuild\jar.py", line 333, in makeJar
27:50.78     self.processJarSection(info, jardir)
27:50.78   File "c:\build\comm-aurora\comm-aurora\mozilla\python\mozbuild\mozbuild\jar.py", line 388, in processJarSection
27:50.78     self._processEntryLine(e, outHelper, jf)
27:50.78   File "c:\build\comm-aurora\comm-aurora\mozilla\python\mozbuild\mozbuild\jar.py", line 449, in _processEntryLine
27:50.78     ', '.join(src_base)))
27:50.78 RuntimeError: File "../locales/de/chrome/calendar/timezones.properties" not found in c:\build\comm-aurora\comm-aurora\calendar\timezones, c:\build\comm-aurora\comm-aurora\obj-i686-pc-mingw32\calendar\timezones
27:50.78 c:/build/comm-aurora/comm-aurora/mozilla/config/rules.mk:1215: recipe for target 'libs' failed
27:50.78 mozmake.EXE[4]: *** [libs] Error 1
27:50.78 c:/build/comm-aurora/comm-aurora/mozilla/config/recurse.mk:79: recipe for target 'calendar/timezones/libs' failed
27:50.78 mozmake.EXE[3]: *** [calendar/timezones/libs] Error 2
27:50.78 c:/build/comm-aurora/comm-aurora/mozilla/config/recurse.mk:32: recipe for target 'libs' failed
27:50.78 mozmake.EXE[2]: *** [libs] Error 2
27:50.78 c:/build/comm-aurora/comm-aurora/mozilla/config/rules.mk:557: recipe for target 'default' failed
27:50.78 mozmake.EXE[1]: *** [default] Error 2
27:50.78 client.mk:406: recipe for target 'build' failed
27:50.78 mozmake.EXE: *** [build] Error 2
27:50.85 231 compiler warnings present.
2

Of course timezones.properties exists, but not at "../locales/de/chrome/calendar/timezones.properties".

I wonder if this is a regression from bug 1139673:
I tried to read the docs (jar manifests) and with the attached changes my builds succeed. But to be honest, I don't really understand what I've done there.
Is anyone able to reproduce and wants to have a look at this?
Component: General → Build Config
Attachment #8733102 - Flags: feedback?(philipp)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Comment on attachment 8733102 [details] [diff] [review]
buildtimezonesl10nfix.v1.diff

Review of attachment 8733102 [details] [diff] [review]:
-----------------------------------------------------------------

I've seen the relativesrcdir thing fix locales before, so this might work. r=philipp
Attachment #8733102 - Flags: feedback?(philipp) → review+
Updated patch, carrying over r+ from first one.
Attachment #8733102 - Attachment is obsolete: true
Attachment #8744698 - Flags: review+
Added checkin-needed. comm-central is sufficient, I guess.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2f0b441e72331d2d52eda74400c05eccf4b7a119
Bug 1258557 - Building localized Lightning fails in /calendar/timezones. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 5.0
Whiteboard: [update target milestone][5.1]
Whiteboard: [update target milestone][5.1]
Target Milestone: 5.0 → 5.1
You need to log in before you can comment on or make changes to this bug.