Closed Bug 1258562 Opened 5 years ago Closed 5 years ago

Crash in dom::MediaSource::Duration

Categories

(Core :: Audio/Video: Playback, defect, P1)

All
Unspecified
defect

Tracking

()

VERIFIED FIXED
mozilla48
Tracking Status
firefox45 blocking fixed
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed
firefox-esr38 --- unaffected
firefox-esr45 --- fixed
relnote-firefox --- 45+

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

(Keywords: crash, topcrash)

Crash Data

Attachments

(1 file)

Top crasher
Assignee: nobody → jyavenard
Blocks: MSE
The assumption was made that this code was never called if MediaSourceDecoder::NextFrameBufferedStatus() had been called before. However, that assumption was incorrect as NextFrameBufferedStatus() is only called if we had determine we had no frame buffered.

Review commit: https://reviewboard.mozilla.org/r/41587/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41587/
Attachment #8733129 - Flags: review?(gsquelart)
Keywords: crash, topcrash
Priority: -- → P1
Hardware: Unspecified → All
Attachment #8733129 - Flags: review?(gsquelart) → review+
Comment on attachment 8733129 [details]
MozReview Request: Bug 1258562: MSE] Abort if MediaSource has been shutdown. r?gerald

https://reviewboard.mozilla.org/r/41587/#review38009
Comment on attachment 8733129 [details]
MozReview Request: Bug 1258562: MSE] Abort if MediaSource has been shutdown. r?gerald

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41587/diff/1-2/
Comment on attachment 8733129 [details]
MozReview Request: Bug 1258562: MSE] Abort if MediaSource has been shutdown. r?gerald

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: this is a top crasher in current release, it will be in ESR for sure.
Fix Landed on Version:
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch: 

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Approval Request Comment
[Feature/regressing bug #]: 1258562
[User impact if declined]: top crasher (> 3.5k in the last week)
[Describe test coverage new/current, TreeHerder]: Manual test, similar fix to bug 1245463
[Risks and why]: None. Only checking that the mediasource object still exists and hasn't been deleted underneath us
[String/UUID change made/needed]: none
Attachment #8733129 - Flags: approval-mozilla-esr45?
Attachment #8733129 - Flags: approval-mozilla-beta?
Attachment #8733129 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/fad8fe6c7c90
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
This crash signature does not show up on Nightly 48.0a1 after build 03-21 which is good news. Based on that I would consider it verified.
Status: RESOLVED → VERIFIED
Hi Jean-Yves, is ESR38 affected as well? Should we uplift this fix on that branch too?
Flags: needinfo?(jyavenard)
Comment on attachment 8733129 [details]
MozReview Request: Bug 1258562: MSE] Abort if MediaSource has been shutdown. r?gerald

Crash fix that has ceased on Nightly since it landed, Aurora47+, Beta46+, ESR45+
Attachment #8733129 - Flags: approval-mozilla-esr45?
Attachment #8733129 - Flags: approval-mozilla-esr45+
Attachment #8733129 - Flags: approval-mozilla-beta?
Attachment #8733129 - Flags: approval-mozilla-beta+
Attachment #8733129 - Flags: approval-mozilla-aurora?
Attachment #8733129 - Flags: approval-mozilla-aurora+
it doesn't affect ESR38 no.
Flags: needinfo?(jyavenard)
Jean-Yves/Anthony, we might do a new dot release for 45. I am considering taking this patch, what do you think?
Flags: needinfo?(jyavenard)
Flags: needinfo?(ajones)
sounds like a good idea, patch should apply to 45 too.
Flags: needinfo?(jyavenard)
Flags: needinfo?(ajones)
Comment on attachment 8733129 [details]
MozReview Request: Bug 1258562: MSE] Abort if MediaSource has been shutdown. r?gerald

[Triage Comment]
For 45 too.
Attachment #8733129 - Flags: approval-mozilla-release+
Added to the release notes with "Fix a crash impacting the video playback with Media Source Extension (1258562)" as wording
You need to log in before you can comment on or make changes to this bug.