NSPR configure.in patch from the FreeBSD Mozilla 0.9.8 port

RESOLVED FIXED in 4.2

Status

NSPR
NSPR
P1
normal
RESOLVED FIXED
17 years ago
4 years ago

People

(Reporter: Wan-Teh Chang, Assigned: hacker formerly known as seawood@netscape.com)

Tracking

other
x86
FreeBSD
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
This bug is a derivative of bug 112987.  I will attach a patch
for nsprpub/configure.in that comes from that bug.
(Reporter)

Comment 1

17 years ago
Created attachment 69827 [details] [diff] [review]
patch for nsprpub/configure.in

Chris,

The ideas of the changes in this patch are fine,
but I'd like you to review and edit them to be
consistent with your indentation and comment style.
(I don't know when to use 'dnl' and when to use '#'.)

Also, the last change in the patch applies not
only to freebsd but also to openbsd, bsdi, and
netbsd.  I am not sure if that's ok.
(Reporter)

Updated

17 years ago
Blocks: 112987
Priority: -- → P1
Target Milestone: --- → 4.2
Version: 3.0 → other
Comment on attachment 69827 [details] [diff] [review]
patch for nsprpub/configure.in

The patch looks fine except for that last piece.  I don't know about openbsd &
netbsd but our bsdi builds were working fine w/o that change.
Attachment #69827 - Flags: needs-work+

Comment 3

17 years ago
Created attachment 71385 [details] [diff] [review]
Revised patch to nsprpub/configure.in

This is a revised patch that puts freebsd in it's own little block, all by
itself...

Regards,
  -Jeremy
Comment on attachment 71385 [details] [diff] [review]
Revised patch to nsprpub/configure.in

r=cls
Attachment #71385 - Flags: review+

Comment 5

17 years ago
a=asa (on behalf of drivers) for checkin to 0.9.9
Keywords: mozilla0.9.9+
The patch has been checked into the nspr trunk & NSPRPUB_PRE_4_2_CLIENT_BRANCH.

Checking in nsprpub/configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.83.2.17; previous revision: 1.83.2.16
done
Checking in nsprpub/configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.78.2.17; previous revision: 1.78.2.16
done


Checking in nsprpub/configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.96; previous revision: 1.95
done
Checking in nsprpub/configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.101; previous revision: 1.100
done

Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

17 years ago
Comment on attachment 71385 [details] [diff] [review]
Revised patch to nsprpub/configure.in

>Index: configure.in
>===================================================================
>RCS file: /cvsroot/mozilla/nsprpub/configure.in,v
>retrieving revision 1.100
>diff -u -r1.100 configure.in
>--- configure.in	2002/01/27 04:50:55	1.100
>+++ configure.in	2002/02/25 23:34:08
>@@ -1997,8 +1998,15 @@
>    if test $? -eq 0; then
> 	if test -z "`egrep -i '(unrecognize|unknown)' conftest.out | grep pthread`" && test -z "`egrep -i '(error|incorrect)' conftest.out`" ; then
> 	    ac_cv_have_dash_pthread=yes
>-	    CFLAGS="$CFLAGS -pthread"
>-	    CXXFLAGS="$CXXFLAGS -pthread"
>+		case "$target_os" in
>+	    freebsd*)
>+# Freebsd doesn't use -pthread for compiles, it uses them for linking
>+            ;;
>+	    *)
>+            CFLAGS="$CFLAGS -pthread"
>+            CXXFLAGS="$CXXFLAGS -pthread"
>+            ;;
>+        esac
> 	fi
>     fi
>     rm -f conftest*

The indentation of the new case statement doesn't
look right whether I set the tab stop to 8, 4, or 2.

Updated

4 years ago
Blocks: 1112904
You need to log in before you can comment on or make changes to this bug.