125857 - NSPR configure.in patch from the FreeBSD Mozilla 0.9.8 port

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Wan-Teh Chang]

This bug is a derivative of bug 112987.  I will attach a patch
for nsprpub/configure.in that comes from that bug.

Comment 1

[Wan-Teh Chang]

Attachment: patch for nsprpub/configure.in

Chris,

The ideas of the changes in this patch are fine,
but I'd like you to review and edit them to be
consistent with your indentation and comment style.
(I don't know when to use 'dnl' and when to use '#'.)

Also, the last change in the patch applies not
only to freebsd but also to openbsd, bsdi, and
netbsd.  I am not sure if that's ok.

Comment 2

[hacker formerly known as [e-mail]]

Comment on attachment 69827 [details] [diff] [review]
patch for nsprpub/configure.in

The patch looks fine except for that last piece.  I don't know about openbsd &
netbsd but our bsdi builds were working fine w/o that change.

Comment 3

[Jeremy Lea]

Attachment: Revised patch to nsprpub/configure.in

This is a revised patch that puts freebsd in it's own little block, all by
itself...

Regards,
  -Jeremy

Comment 4

[hacker formerly known as [e-mail]]

Comment on attachment 71385 [details] [diff] [review]
Revised patch to nsprpub/configure.in

r=cls

Comment 5

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.9

Comment 6

[hacker formerly known as [e-mail]]

The patch has been checked into the nspr trunk & NSPRPUB_PRE_4_2_CLIENT_BRANCH.

Checking in nsprpub/configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.83.2.17; previous revision: 1.83.2.16
done
Checking in nsprpub/configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.78.2.17; previous revision: 1.78.2.16
done


Checking in nsprpub/configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.96; previous revision: 1.95
done
Checking in nsprpub/configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.101; previous revision: 1.100
done

Comment 7

[Wan-Teh Chang]

Comment on attachment 71385 [details] [diff] [review]
Revised patch to nsprpub/configure.in

>Index: configure.in
>===================================================================
>RCS file: /cvsroot/mozilla/nsprpub/configure.in,v
>retrieving revision 1.100
>diff -u -r1.100 configure.in
>--- configure.in	2002/01/27 04:50:55	1.100
>+++ configure.in	2002/02/25 23:34:08
>@@ -1997,8 +1998,15 @@
>    if test $? -eq 0; then
> 	if test -z "`egrep -i '(unrecognize|unknown)' conftest.out | grep pthread`" && test -z "`egrep -i '(error|incorrect)' conftest.out`" ; then
> 	    ac_cv_have_dash_pthread=yes
>-	    CFLAGS="$CFLAGS -pthread"
>-	    CXXFLAGS="$CXXFLAGS -pthread"
>+		case "$target_os" in
>+	    freebsd*)
>+# Freebsd doesn't use -pthread for compiles, it uses them for linking
>+            ;;
>+	    *)
>+            CFLAGS="$CFLAGS -pthread"
>+            CXXFLAGS="$CXXFLAGS -pthread"
>+            ;;
>+        esac
> 	fi
>     fi
>     rm -f conftest*

The indentation of the new case statement doesn't
look right whether I set the tab stop to 8, 4, or 2.