Closed
Bug 1258589
Opened 10 years ago
Closed 10 years ago
Support building C++ tests for 32-bit x86 Mac OS X
Categories
(NSS :: Build, defect, P2)
Tracking
(firefox48 affected)
RESOLVED
FIXED
3.24
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | affected |
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
ekr
:
review+
mt
:
superreview+
wtc
:
checked-in+
|
Details | Diff | Splinter Review |
When building NSS on Mac OS X, if USE_64 is not set, we
do a 32-bit x86 build. This is accomplished by passing the
-arch i386 flag to compilers. Right now we only add the
-arch i386 flag to the C compiler. We should also add that
flag to the C++ compiler.
The attached patch does that.
Attachment #8733161 -
Flags: superreview?(martin.thomson)
Attachment #8733161 -
Flags: review?(ekr)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8733161 [details] [diff] [review]
Patch
Review of attachment 8733161 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8733161 -
Flags: review?(ekr) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8733161 [details] [diff] [review]
Patch
https://hg.mozilla.org/projects/nss/rev/63870dfa0646
Attachment #8733161 -
Flags: checked-in+
|
|
Assignee | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Attachment #8733161 -
Flags: superreview?(martin.thomson) → superreview+
You need to log in
before you can comment on or make changes to this bug.
Description
•