Closed Bug 1258615 Opened 4 years ago Closed 4 years ago

Remove the "magic" that sets a result from set_config() in @depends functions

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Currently, if a @depends function doesn't have a return statement or
return None, a result is automatically set from all the set_config()
called from the function.

As we're going to move set_config to the global namespace, and as this
feature is only used once, and it's only used for something that was
written before ReadOnlyNamespace was exposed to the sandbox, we can
"safely" get rid of it.

Review commit: https://reviewboard.mozilla.org/r/41655/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41655/
Attachment #8733227 - Flags: review?(cmanchester)
Comment on attachment 8733227 [details]
MozReview Request: Bug 1258615 - Remove the "magic" that sets a result from set_config() in @depends functions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41655/diff/1-2/
Comment on attachment 8733227 [details]
MozReview Request: Bug 1258615 - Remove the "magic" that sets a result from set_config() in @depends functions

https://reviewboard.mozilla.org/r/41655/#review38191

I don't think I'll miss it at all.
Attachment #8733227 - Flags: review?(cmanchester) → review+
https://hg.mozilla.org/mozilla-central/rev/1f6d8c58450f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.