1258615 - Remove the "magic" that sets a result from set_config() in @depends functions

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1258615 - Remove the "magic" that sets a result from set_config() in @depends functions

Currently, if a @depends function doesn't have a return statement or
return None, a result is automatically set from all the set_config()
called from the function.

As we're going to move set_config to the global namespace, and as this
feature is only used once, and it's only used for something that was
written before ReadOnlyNamespace was exposed to the sandbox, we can
"safely" get rid of it.

Review commit: https://reviewboard.mozilla.org/r/41655/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/41655/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8733227 [details]
MozReview Request: Bug 1258615 - Remove the "magic" that sets a result from set_config() in @depends functions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/41655/diff/1-2/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8733227 [details]
MozReview Request: Bug 1258615 - Remove the "magic" that sets a result from set_config() in @depends functions

https://reviewboard.mozilla.org/r/41655/#review38191

I don't think I'll miss it at all.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f6d8c58450f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f6d8c58450f