1258626 - Implement mask-repeat: [space | round]

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[Astley Chen (inactive)]

The implementation will depend on bug548372.

Comment 1

[Astley Chen (inactive)]

Reference:
[space] - http://astleychen.github.io/css-masking/bug1258623/mask-repeat-2-ref.html
[round] - http://astleychen.github.io/css-masking/bug1258623/mask-repeat-3-ref.html

Tested:
[space] - http://astleychen.github.io/css-masking/bug1258623/mask-repeat-2.html
[round] - http://astleychen.github.io/css-masking/bug1258623/mask-repeat-3.html

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Given that we don't support this for background-image, I don't think this needs to block shipping support for mask-image.

(It would be good to do it for both at some point, though.)

Comment 4

[Astley Chen (inactive)]

(In reply to David Baron [:dbaron] ⌚️UTC-7 (review requests must explain patch) (busy May 9-13) from comment #3)
> Given that we don't support this for background-image, I don't think this
> needs to block shipping support for mask-image.
> 
> (It would be good to do it for both at some point, though.)

Agreed per your comments.
In fact, Ethan is working on bug 548372 and it's on the half way.
mask-repeat:space|round support can be done as soon as bug 548372 is fixed since they probably share most of the implementation. In that case, we are able to ship mask-image in one piece and it's the plan for now.

Comment 5

[Ethan Lin[:ethlin]]

I will work on this after bug 548372.

Comment 6

[Ethan Lin[:ethlin]]

(In reply to Astley Chen [:astley] (UTC+8) from comment #1)
> Reference:
> [space] -
> http://astleychen.github.io/css-masking/bug1258623/mask-repeat-2-ref.html
> [round] -
> http://astleychen.github.io/css-masking/bug1258623/mask-repeat-3-ref.html
> 
> Tested:
> [space] -
> http://astleychen.github.io/css-masking/bug1258623/mask-repeat-2.html
> [round] -
> http://astleychen.github.io/css-masking/bug1258623/mask-repeat-3.html

After bug 548372, the above tests can pass on my device. I will send try server to make sure.

Comment 7

[Ethan Lin[:ethlin]]

try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d3d5f8e8668&selectedJob=21507581

The tests 'mask-repeat-2.html' and 'mask-repeat-3.html' pass now.

Comment 8

[Jean-Yves Perrier [:teoli]]

The main page was already ok, so I just added a comment there:
https://developer.mozilla.org/en-US/Firefox/Releases/49#CSS