Closed Bug 1258626 Opened 4 years ago Closed 4 years ago

Implement mask-repeat: [space | round]

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
mozilla49

People

(Reporter: bmo, Assigned: ethlin)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-complete)

The implementation will depend on bug548372.
Duplicate of this bug: 1244609
Given that we don't support this for background-image, I don't think this needs to block shipping support for mask-image.

(It would be good to do it for both at some point, though.)
No longer blocks: mask-image, mask-ship
(In reply to David Baron [:dbaron] ⌚️UTC-7 (review requests must explain patch) (busy May 9-13) from comment #3)
> Given that we don't support this for background-image, I don't think this
> needs to block shipping support for mask-image.
> 
> (It would be good to do it for both at some point, though.)

Agreed per your comments.
In fact, Ethan is working on bug 548372 and it's on the half way.
mask-repeat:space|round support can be done as soon as bug 548372 is fixed since they probably share most of the implementation. In that case, we are able to ship mask-image in one piece and it's the plan for now.
I will work on this after bug 548372.
Assignee: nobody → ethlin
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla49
(In reply to Astley Chen [:astley] (UTC+8) from comment #1)
> Reference:
> [space] -
> http://astleychen.github.io/css-masking/bug1258623/mask-repeat-2-ref.html
> [round] -
> http://astleychen.github.io/css-masking/bug1258623/mask-repeat-3-ref.html
> 
> Tested:
> [space] -
> http://astleychen.github.io/css-masking/bug1258623/mask-repeat-2.html
> [round] -
> http://astleychen.github.io/css-masking/bug1258623/mask-repeat-3.html

After bug 548372, the above tests can pass on my device. I will send try server to make sure.
try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d3d5f8e8668&selectedJob=21507581

The tests 'mask-repeat-2.html' and 'mask-repeat-3.html' pass now.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
The main page was already ok, so I just added a comment there:
https://developer.mozilla.org/en-US/Firefox/Releases/49#CSS
You need to log in before you can comment on or make changes to this bug.