1258722 - The user should be able to enter/exit full screen via double click event even if video controls are hidden

Status: RESOLVED INVALID

(Core :: Audio/Video: Playback, enhancement)

Description

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

[Note]:
- I observed this issue for .webm, .ogv, .mp4, VP8 and VP9 video formats.

[Affected versions]:
- 37.0a1 (2014-11-30)
- 44.0.2-build3 (20160210153822)
- 45.0.1 (20160315153207)
- 46.0b4-build1 (20160321115535)
- 47.0a2 (2016-03-22)
- 48.0a1 (2016-03-22)

[Affected platforms]:
- Windows 10 x64
- Mac OS X 10.8
- Ubuntu 14.04 x64

[Steps to reproduce]:
1. Launch Firefox.
2. Open the following video http://techslides.com/demos/sample-videos/small.webm.
3. Play the video in normal size.
4. Click the Hide Controls Context Menu option.
5. Double click on the video in order to enter the full screen.
6. Play the video in full screen, using the Full Screen Context Menu option.
7. Double click on the video in order to exit the full screen.

[Expected result]:
The user should be able to enter full screen via mouse event even if video controls are hidden.

[Actual result]:
Mouse controls are not working if video controls are hidden.

[Additional notes]:
- We traced this all the way back to Fx37, so this is not a regression. It's very likely this is reproducible on older builds as well.
- Please note that, although double-clicking doesn't toggle the full screen state, the context menu can still be brought up via right-click.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

It is possible; right click -> full screen. Press Shift + Right Click to punch through intervening layers to reach underlying element.

Comment 2

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

(In reply to Chris Pearce (:cpearce) from comment #1)
> It is possible; right click -> full screen. Press Shift + Right Click to
> punch through intervening layers to reach underlying element.

I wanted to highlight that the user is unable to control fullscreen by double click if video controls are hidden. Also, I mentioned that although double-clicking doesn't toggle the full screen state, the context menu can still be brought up via right-click.

Comment 3

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

oops, forgot the ni? :)

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

I don't think it's a good idea for us to add controls to videos that sites didn't set the "controls" attribute. Sites that don't use our built in controls videos typically have custom controls that we could be interfering with.