Closed Bug 1258758 Opened 4 years ago Closed 4 years ago

Rename GetEffectiveClipRect to GetLocalClipRect


(Core :: Graphics: Layers, defect)

48 Branch
Not set



Tracking Status
firefox48 --- affected
firefox49 --- fixed


(Reporter: kats, Assigned: ronoueb)


(Blocks 1 open bug)


(Keywords: arch, Whiteboard: [gfx-noted])


(1 file, 1 obsolete file)

GetEffectiveClipRect returns either the shadow clip rect (for shadow layers) or the regular clip rect (for regular layers). As per the naming convention in bug 1247442, we should rename this to GetLocalClipRect.
Attached patch rename GetEffectiveClipRect (obsolete) — Splinter Review
Attachment #8747725 - Flags: review?(bugmail.mozilla)
Comment on attachment 8747725 [details] [diff] [review]
rename GetEffectiveClipRect

Review of attachment 8747725 [details] [diff] [review]:

Nice, thanks! It looks like there's also a couple of references to GetEffectiveClipRect in widget/gonk/HwcComposer2D.cpp - could you update those as well? That code is only built for Firefox OS which is not a tier-1 platform so technically we don't need to make the change but it's simple enough and it would be nice to not break their build. The other change I'd like you to make is in the commit message - r=kats instead of With those two changes this patch should be ready to land; if you upload a new version I can land it for you.
Attachment #8747725 - Flags: review?(bugmail.mozilla) → feedback+
Assignee: nobody → bd339
Attachment #8747725 - Attachment is obsolete: true
Attachment #8747742 - Flags: review?(bugmail.mozilla)
Comment on attachment 8747742 [details] [diff] [review]
rename GetEffectiveClipRect 2nd revision

Review of attachment 8747742 [details] [diff] [review]:

Perfect, thanks! I'll land this shortly.
Attachment #8747742 - Flags: review?(bugmail.mozilla) → review+
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.