1258835 - Give tests easier means to spin up calendar services

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Right now we have a lot of tests that run either one of the calendar services, or manually spin up various services. It would be nice to simplify this a bit.

I noticed some of our tests are swallowing errors that timezones are not defined because they are not spinning up the timezone service.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

Geoff, can you take a look at this patch?

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 8733544 [details] [diff] [review]
Fix - v1

Review of attachment 8733544 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/test/unit/test_storage.js
@@ +2,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  function run_test() {
> +    do_calendar_startup(run_next_test);

This doesn't apply properly, I think you must have another patch applied.

@@ +7,3 @@
>  }
>  
> +add_task(function testAttachRoundtrip() {

Should be add_test, no?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Geoff Lankow (:darktrojan) from comment #2)
> This doesn't apply properly, I think you must have another patch applied.

Yes, I have bug 1115667 applied, sorry about that!

> > +add_task(function testAttachRoundtrip() {
> 
> Should be add_test, no?
Good catch!

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v2

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Please push this together with bug 1115667 (applies on top of the patches in that bug)

Comment 6

[:aceman]

There was a slight conflict in test_items.js. Hopefully I fixed it correctly:
https://hg.mozilla.org/comm-central/rev/69b4c4164312c107137efa4fae17c63608fa30d1

Comment 7

[Stefan Sitter [:ssitter]]

This regressed Bug 1264782.