Closed
Bug 1258899
Opened 8 years ago
Closed 8 years ago
Web Manifest: Implement processing the dir member
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: marcosc, Assigned: marcosc)
References
(Blocks 1 open bug, )
Details
(Whiteboard: btpp-active)
Attachments
(1 file, 1 obsolete file)
4.79 KB,
patch
|
Details | Diff | Splinter Review |
Implement processing the newly added dir member.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Blocks: webmanifest
Assignee | ||
Comment 1•8 years ago
|
||
Small addition to the manifest processor to handle `dir` member. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e73d7ba2e61
Updated•8 years ago
|
Whiteboard: btpp-active
Comment 2•8 years ago
|
||
Comment on attachment 8738877 [details] [diff] [review] 0001-Bug-1258899-teach-manifest-processor-about-dir-membe.patch Review of attachment 8738877 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/manifest/ManifestProcessor.jsm @@ +52,4 @@ > get orientationTypes() { > return orientationTypes; > }, > + get textDirections(){ space between ) and { @@ +103,4 @@ > processedManifest.scope = processScopeMember(); > return processedManifest; > > + function processDirMember(){ also here )<space>{ ::: dom/manifest/test/test_ManifestProcessor_dir.html @@ +36,5 @@ > + > +//trim tests > +validDirs.forEach((dir) => { > + var expected = `Expect trimmed dir to be returned.`; > + var expandeddir = seperators + lineTerminators + dir + lineTerminators + seperators; seperators?
Attachment #8738877 -
Flags: review?(amarchesini) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•8 years ago
|
||
> seperators?
Will fix as a "seperate" bug ;) Lots of copy pasta.
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8738877 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7f6bb7c5af78
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•