Closed Bug 1258899 Opened 4 years ago Closed 4 years ago

Web Manifest: Implement processing the dir member

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug, )

Details

(Whiteboard: btpp-active)

Attachments

(1 file, 1 obsolete file)

Implement processing the newly added dir member.
Blocks: webmanifest
Small addition to the manifest processor to handle `dir` member. 

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e73d7ba2e61
Assignee: nobody → mcaceres
Status: NEW → ASSIGNED
Attachment #8738877 - Flags: review?(amarchesini)
Whiteboard: btpp-active
Comment on attachment 8738877 [details] [diff] [review]
0001-Bug-1258899-teach-manifest-processor-about-dir-membe.patch

Review of attachment 8738877 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/manifest/ManifestProcessor.jsm
@@ +52,4 @@
>    get orientationTypes() {
>      return orientationTypes;
>    },
> +  get textDirections(){

space between ) and {

@@ +103,4 @@
>      processedManifest.scope = processScopeMember();
>      return processedManifest;
>  
> +    function processDirMember(){

also here )<space>{

::: dom/manifest/test/test_ManifestProcessor_dir.html
@@ +36,5 @@
> +
> +//trim tests
> +validDirs.forEach((dir) => {
> +  var expected = `Expect trimmed dir to be returned.`;
> +  var expandeddir =  seperators + lineTerminators + dir + lineTerminators + seperators;

seperators?
Attachment #8738877 - Flags: review?(amarchesini) → review+
Keywords: checkin-needed
Keywords: checkin-needed
> seperators?

Will fix as a "seperate" bug ;) Lots of copy pasta.
Attached patch Fixed nitsSplinter Review
Attachment #8738877 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7f6bb7c5af78
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.