1258899 - Web Manifest: Implement processing the dir member

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marcos Caceres [:marcosc]]

Implement processing the newly added dir member.

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: 0001-Bug-1258899-teach-manifest-processor-about-dir-membe.patch

Small addition to the manifest processor to handle `dir` member. 

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e73d7ba2e61

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8738877 [details] [diff] [review]
0001-Bug-1258899-teach-manifest-processor-about-dir-membe.patch

Review of attachment 8738877 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/manifest/ManifestProcessor.jsm
@@ +52,4 @@
>    get orientationTypes() {
>      return orientationTypes;
>    },
> +  get textDirections(){

space between ) and {

@@ +103,4 @@
>      processedManifest.scope = processScopeMember();
>      return processedManifest;
>  
> +    function processDirMember(){

also here )<space>{

::: dom/manifest/test/test_ManifestProcessor_dir.html
@@ +36,5 @@
> +
> +//trim tests
> +validDirs.forEach((dir) => {
> +  var expected = `Expect trimmed dir to be returned.`;
> +  var expandeddir =  seperators + lineTerminators + dir + lineTerminators + seperators;

seperators?

Comment 3

[Marcos Caceres [:marcosc]]

> seperators?

Will fix as a "seperate" bug ;) Lots of copy pasta.

Comment 4

[Marcos Caceres [:marcosc]]

Attachment: Fixed nits

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7f6bb7c5af78

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f6bb7c5af78