1258912 - Split pwmgr_common.js into separate content and chrome scripts

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[Matthew N. [:MattN]]

pwmgr_common.js was made to work in both content and chrome processes in order to ease the incremental transition to all tests running with support for e10s. This makes it a bit messy as functions which are adjacent in the file could be intended for different processes but that's isn't obvious.

We should split the file into content helpers which send messages to the parent when necessary and the chrome code which talks to the login manager.

As much as possible in the chrome code should move to LoginTestUtils.jsm or re-use what's there so we can share common helpers between test suites.

I think it will be easiest to do this once all tests work in e10s so we can see what remaining helpers we actually need since many things are getting cleaned up with rewrites/ports.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1258912 - Split pwmgr_common.js into separate content and chrome scripts. r=jaws

This depends on bug 1520966 landing first.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1258912 - Enable the no-unused-vars eslint rule in pwmgr tests. r=jaws

Depends on D18164

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1258912 - Enable the no-undef rule in pwmgr tests. r=jaws

Depends on D18167

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7a12059919a
Split pwmgr_common.js into separate content and chrome scripts. r=jaws
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fccec2f53f8
Enable the no-unused-vars eslint rule in pwmgr tests. r=jaws
https://hg.mozilla.org/integration/mozilla-inbound/rev/16803b8b2997
Enable the no-undef rule in pwmgr tests. r=jaws

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c7a12059919a
https://hg.mozilla.org/mozilla-central/rev/0fccec2f53f8
https://hg.mozilla.org/mozilla-central/rev/16803b8b2997