Remove "Error console" menuitem and pref

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, relnote-firefox 48+)

Details

Attachments

(1 attachment, 2 obsolete attachments)

I would be surprised if anyone still use it in Firefox.
Based on this thread:
  https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4

We will remove the menuitem and pref while keeping the Console itself for other projects that may still use it: Seamonkey, thunderbird?
Assignee: nobody → poirot.alex
Is that fine for you?

Do you think we can drop the Console soon?
It looks like you are making good progress on supporting devtools in Seamonkey.
Are you also doing that for Thunderbird?
Flags: needinfo?(philip.chee)
> We will remove the menuitem and pref while keeping the Console itself for
> other projects that may still use it: Seamonkey, thunderbird?
This is fine as long as SeaMonkey and Thunderbird can still access the toolkit Error Console.

> Do you think we can drop the Console soon?
I don't think you should remove the actual Error Console code in /toolkit/. We could move it to comm-central in extremis

> It looks like you are making good progress on supporting devtools in Seamonkey.
> Are you also doing that for Thunderbird?
:Fallen is the Thunderbird person to ask. It is unclear how to support Thunderbird given that Devtools has implicit assumptions that it is running in a browser/tabbrowser environment. I do not know how much of a rewrite is needed in /devtools/ or even if you want to devote any resources to this.
Flags: needinfo?(philipp)
Flags: needinfo?(philip.chee)
There are currently no plans to move to Browser Console in Thunderbird, because the Error Console is working fine. As mentioned, Thunderbird doesn't have the classic concept of a browser window, so it may be hard to migrate.

What would be needed to launch the browser console in an app like Thunderbird? I assume I'll have to switch the MOZ_ variable to include the client code, then do <something> to launch the browser console?
Flags: needinfo?(philipp) → needinfo?(poirot.alex)
Thanks Phillip and Phillipp for the feedback. I'll just remove the menuitem and pref related to Firefox.
It shouldn't change anything for other products.

But it would be great to migrate all products to devtools. The old Error Console is no longer maintained.
We have been added many features for years now to the Browser Console and other tools.
You should also be able to use the "Browser Toolbox".

I might not work as-is. But I think it is worth time spent to get the devtools working.
We recently moved devtools codebase out of /browser/.
It now lives in /devtools/. So it is possible to ship devtools into other products!
You can do that simply by setting MOZ_DEVTOOLS=all
  http://mxr.mozilla.org/mozilla-central/source/browser/confvars.sh#70
There might also need some tweaks to package-manifest.in to include the files in the packaged builds:
  http://mxr.mozilla.org/mozilla-central/source/browser/installer/package-manifest.in#678

Then, most of our codebase is browser oriented. But some parts like the Browser console and Browser toolbox are also meant to work for xulrunner apps. (The names are poorly choosen as they are not browser specific)

Once you managed to ship /devtools/ into your product, you should be able to open a browser toolbox via code like this:
let { loader } = Components.utils.import("resource://devtools/shared/Loader.jsm", {});
// if bug 1247203 *is NOT* in your branch
loader.require("devtools/client/framework/devtools-browser");
// if bug 1247203 *is* in your branch
loader.main("devtools/client/main");

let hudservice = loader.require("devtools/client/webconsole/hudservice");
hudservice.toggleBrowserConsole();

If you consider actually doing it, please open a related bug, I would be happy to help.
I recently moved the very last bit of devtools from /browser/ to /devtools/ and would be happy to followup in order to ensure our codebase works easily for other products.
Flags: needinfo?(poirot.alex)
Posted patch patch v1 (obsolete) — Splinter Review
Posted patch patch v2 (obsolete) — Splinter Review
Rebase.
Attachment #8737780 - Flags: review?(jryans)
Attachment #8735786 - Attachment is obsolete: true
Release Note Request (optional, but appreciated)
[Why is this notable]:
Some developers may still use this old console, but should really switch to the Browser console:
  https://developer.mozilla.org/en/docs/Tools/Browser_Console
The "Error console", which has been disabled here has been now deprecated for a long time and has been prefed off since then.

[Links (documentation, blog post, etc)]:
Started a discussion here to announce a possible removal:
https://groups.google.com/forum/#!topic/mozilla.dev.developer-tools/XYPqQ58ndX4
relnote-firefox: --- → ?
Comment on attachment 8737780 [details] [diff] [review]
patch v2

Review of attachment 8737780 [details] [diff] [review]:
-----------------------------------------------------------------

It seems like you should also remove all other references to the pref:

https://dxr.mozilla.org/mozilla-central/search?q=devtools.errorconsole.enabled&redirect=false&case=true
Attachment #8737780 - Flags: review?(jryans) → review+
Posted patch patch v3Splinter Review
Remove other pref references.
Attachment #8738084 - Flags: review+
Attachment #8737780 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/7e34593bd9edad80833782f1c94e0f40fdb3ff4b
Bug 1258985 - Remove menuitem and pref related to the "Error Console". r=jryans
https://hg.mozilla.org/mozilla-central/rev/7e34593bd9ed
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Blocks: 1263186
Added to Fx48 Aurora release notes
Maybe link 'Browser Console' in the release note to https://developer.mozilla.org/en-US/docs/Tools/Browser_Console and remove the quotes around both?

Sebastian
Flags: needinfo?(rkothari)
(In reply to Sebastian Zartner [:sebo] from comment #13)
> Maybe link 'Browser Console' in the release note to
> https://developer.mozilla.org/en-US/docs/Tools/Browser_Console and remove
> the quotes around both?
> 
> Sebastian

Done!
Flags: needinfo?(rkothari)
Depends on: 1302738
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.