1258989 - Switch gtk3drawing to a C++ file

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

It would be great to have C++ abilities for the upcoming gtk3.20 changes.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

This is really a minimal patch which leaves gtk2 code as is. I think we may figure later how to incorporate the gtk2 code to keep compatibility with the gtk3.20 changes. But if you want gtk2drawing also transfer to c++ now I'll do that.

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8733831 [details] [diff] [review]
patch

Thanks, Martin!  Performing this change separately is very helpful.

Nice to see the correct pointer casts.  Safer pointer type checking alone would be good enough reason to move to C++.

I'd be inclined to change the GTK2 code as little as possible.
You may be the only person maintaining it, so whatever is easiest for you.

Comment 3

[Bill Gianopoulos [:WG9s]]

I thought all c code was supposed to be c++ expect for that imprted form an upstream project that may be in c.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8733831 [details] [diff] [review]
patch

Thanks! Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e81ba25c94f8

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd5195ffa672

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd5195ffa672