Closed
Bug 1258989
Opened 8 years ago
Closed 8 years ago
Switch gtk3drawing to a C++ file
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: stransky, Unassigned)
References
Details
Attachments
(1 file)
17.89 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
It would be great to have C++ abilities for the upcoming gtk3.20 changes.
Reporter | ||
Comment 1•8 years ago
|
||
This is really a minimal patch which leaves gtk2 code as is. I think we may figure later how to incorporate the gtk2 code to keep compatibility with the gtk3.20 changes. But if you want gtk2drawing also transfer to c++ now I'll do that.
Attachment #8733831 -
Flags: review?(karlt)
Comment 2•8 years ago
|
||
Comment on attachment 8733831 [details] [diff] [review] patch Thanks, Martin! Performing this change separately is very helpful. Nice to see the correct pointer casts. Safer pointer type checking alone would be good enough reason to move to C++. I'd be inclined to change the GTK2 code as little as possible. You may be the only person maintaining it, so whatever is easiest for you.
Attachment #8733831 -
Flags: review?(karlt) → review+
Comment 3•8 years ago
|
||
I thought all c code was supposed to be c++ expect for that imprted form an upstream project that may be in c.
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8733831 [details] [diff] [review] patch Thanks! Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e81ba25c94f8
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fd5195ffa672
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•