Switch gtk3drawing to a C++ file

RESOLVED FIXED in Firefox 48

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: stransky, Unassigned)

Tracking

Trunk
mozilla48
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
It would be great to have C++ abilities for the upcoming gtk3.20 changes.
(Reporter)

Comment 1

3 years ago
Created attachment 8733831 [details] [diff] [review]
patch

This is really a minimal patch which leaves gtk2 code as is. I think we may figure later how to incorporate the gtk2 code to keep compatibility with the gtk3.20 changes. But if you want gtk2drawing also transfer to c++ now I'll do that.
Attachment #8733831 - Flags: review?(karlt)
Comment on attachment 8733831 [details] [diff] [review]
patch

Thanks, Martin!  Performing this change separately is very helpful.

Nice to see the correct pointer casts.  Safer pointer type checking alone would be good enough reason to move to C++.

I'd be inclined to change the GTK2 code as little as possible.
You may be the only person maintaining it, so whatever is easiest for you.
Attachment #8733831 - Flags: review?(karlt) → review+
I thought all c code was supposed to be c++ expect for that imprted form an upstream project that may be in c.
(Reporter)

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fd5195ffa672
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.