Closed Bug 1258989 Opened 6 years ago Closed 6 years ago
Switch gtk3drawing to a C++ file
It would be great to have C++ abilities for the upcoming gtk3.20 changes.
This is really a minimal patch which leaves gtk2 code as is. I think we may figure later how to incorporate the gtk2 code to keep compatibility with the gtk3.20 changes. But if you want gtk2drawing also transfer to c++ now I'll do that.
Attachment #8733831 - Flags: review?(karlt)
Comment on attachment 8733831 [details] [diff] [review] patch Thanks, Martin! Performing this change separately is very helpful. Nice to see the correct pointer casts. Safer pointer type checking alone would be good enough reason to move to C++. I'd be inclined to change the GTK2 code as little as possible. You may be the only person maintaining it, so whatever is easiest for you.
Attachment #8733831 - Flags: review?(karlt) → review+
I thought all c code was supposed to be c++ expect for that imprted form an upstream project that may be in c.
Comment on attachment 8733831 [details] [diff] [review] patch Thanks! Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e81ba25c94f8
You need to log in before you can comment on or make changes to this bug.