1259020 - Incorrect string in Settings on devices with no Touch ID support

Status: VERIFIED FIXED

(Firefox for iOS :: Login Management, defect)

Description

[Catalin Suciu [:csuciu]]

On iPhone 4S and all iPods there's no support for Touch ID. Hence, Touch ID should not be mentioned in the 'Touch ID & Passcode' title on these devices.

Comment 1

[Stephan Leroux [:sleroux]]

We have the string 'Set Passcode' already translated as part of a screen in the app. Would it make sense to replace the title of the setting to that when Touch ID is disabled/unavailable?

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: Github PR https://github.com/mozilla/firefox-ios/pull/1659

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8734010 [details] [review]
Github PR https://github.com/mozilla/firefox-ios/pull/1659

Changes look OK to me if we want them, but worth double-checking with the l10n team that do (if you haven't already).

"Touch ID & Passcode" is a noun grouping the set of actions; "Set Passcode" is a specific action. It's a passable substitution English, but might not work as well in other languages.

Comment 4

[Francesco Lodolo [:flod]]

Reusing a string in a completely different context is not a good idea.

I would keep the current string in 3.0 and fix it properly (with a new string) in 4.0 (it's not clear to me which version this fix is targeting).

Comment 5

[Stephan Leroux [:sleroux]]

I've updated the patch to use the "Passcode" string we use for the section title within the "Touch ID & Passcode" screen in place of "Touch ID & Passcode" when the device has no Touch ID support or if it's disabled. 

I believe the context should be fine since they are both used as titles. The only issue is that the localization comment won't make sense since it's now also used for the title of a screen and the button text. Ideally we would want this resolved for the upcoming 3.0 release instead of 4.0 since mentioning 'Touch ID' within an app on a device which doesn't support it may cause Apple to reject the submission.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Stephan Leroux [:sleroux] from comment #5)
> The only issue is that the localization comment won't make sense since it's now
> also used for the title of a screen and the button text.

Button text? As far as I can tell it's used as a section title above "Turn Passcode On", am I missing another usage?
We can update the existing note: "Section title for passcode settings".

Also, given the current choice of using English strings as IDs, I don't think that we have any alternatives (we can't have two "Passcode" strings).

Comment 7

[Stephan Leroux [:sleroux]]

> Button text? As far as I can tell it's used as a section title above "Turn Passcode On", am I missing another usage?

The 'Touch ID & Passcode' string is also used on the main settings page as the list item title to navigate to that screen.

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Stephan Leroux [:sleroux] from comment #7)
> The 'Touch ID & Passcode' string is also used on the main settings page as
> the list item title to navigate to that screen.

Right, I was looking at "Passcode". The reality is that we're already reusing the string "Touch ID & Passcode" both as list item and title (ideally we shouldn't), aren't we? So I don't believe it's an issue if we do the same for Passcode.

Comment 9

[Stephan Leroux [:sleroux]]

> The reality is that we're already reusing the string "Touch ID & Passcode" both as list item and title (ideally we shouldn't), aren't we?

Yup

Comment 10

[Stephan Leroux [:sleroux]]

master 840e195985f14bbc9d712776eb2a4d2ca902e061

Comment 11

[Stephan Leroux [:sleroux]]

v3.x 6fdb136

Comment 12

[Catalin Suciu [:csuciu]]

Verified the following on 3.0b8:

- On iPod 6th gen and iPhone 4S (both with no Touch ID support)
       - the setting title and the section title is Passcode

- On iPad Air 2 
       - with the passcode turned off in iOS settings, the setting title and the section title is 'Passcode'   
       - with the passcode turned on in iOS settings but no fingerprint saved, the setting title and the section title is 'Passcode'
       - with the passcode turned on in iOS settings and a fingerprint saved, the setting title and the section title is 'Touch ID & Passcode'

Based on the above, I'm marking the bug as verified on 3.0

Comment 13

[Simon Basca [:SimonB]]

Verified as fixed on 4.0.0b1.