Increase timeout of notifications from 12s to 20s to match parity with Chromium

RESOLVED FIXED in Firefox 46

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

(Blocks 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed, firefox47 fixed, firefox48 fixed)

Details

Attachments

(1 attachment)

No description provided.
Comment on attachment 8733956 [details]
MozReview Request: Bug 1259108 - Increase timeout of notifications from 12s to 20s to match parity with Chromium. r?mattn

https://reviewboard.mozilla.org/r/42049/#review38501
Attachment #8733956 - Flags: review?(MattN+bmo) → review+
Be careful of test timeouts with this change if we ever test the duration or auto-close. The additional 8s may take us over a threshold.
Comment on attachment 8733956 [details]
MozReview Request: Bug 1259108 - Increase timeout of notifications from 12s to 20s to match parity with Chromium. r?mattn

Approval Request Comment
[Feature/regressing bug #]: adjustment to push notification behavior based on feedback from a partner
[User impact if declined]: shorter notification timeout compared to other browsers
[Describe test coverage new/current, TreeHerder]: manual testing, simple change to the timeout duration
[Risks and why]: no risk expected
[String/UUID change made/needed]: none
Attachment #8733956 - Flags: approval-mozilla-beta?
Attachment #8733956 - Flags: approval-mozilla-aurora?
(I'd also note that 3rd party sites we're working with have expressed that they are very keen on having Firefox increase the timeout.)
Blocks: 1259207
https://hg.mozilla.org/mozilla-central/rev/95bfe6301ba7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Comment on attachment 8733956 [details]
MozReview Request: Bug 1259108 - Increase timeout of notifications from 12s to 20s to match parity with Chromium. r?mattn

Increasing notification timeout based on partner/end-user feedback, Aurora47+, Beta46+
Attachment #8733956 - Flags: approval-mozilla-beta?
Attachment #8733956 - Flags: approval-mozilla-beta+
Attachment #8733956 - Flags: approval-mozilla-aurora?
Attachment #8733956 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.