1259108 - Increase timeout of notifications from 12s to 20s to match parity with Chromium

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: MozReview Request: Bug 1259108 - Increase timeout of notifications from 12s to 20s to match parity with Chromium. r?mattn

Review commit: https://reviewboard.mozilla.org/r/42049/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42049/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8733956 [details]
MozReview Request: Bug 1259108 - Increase timeout of notifications from 12s to 20s to match parity with Chromium. r?mattn

https://reviewboard.mozilla.org/r/42049/#review38501

Comment 3

[Matthew N. [:MattN]]

Be careful of test timeouts with this change if we ever test the duration or auto-close. The additional 8s may take us over a threshold.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95bfe6301ba7

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8733956 [details]
MozReview Request: Bug 1259108 - Increase timeout of notifications from 12s to 20s to match parity with Chromium. r?mattn

Approval Request Comment
[Feature/regressing bug #]: adjustment to push notification behavior based on feedback from a partner
[User impact if declined]: shorter notification timeout compared to other browsers
[Describe test coverage new/current, TreeHerder]: manual testing, simple change to the timeout duration
[Risks and why]: no risk expected
[String/UUID change made/needed]: none

Comment 6

[Justin Dolske [:Dolske]]

(I'd also note that 3rd party sites we're working with have expressed that they are very keen on having Firefox increase the timeout.)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/95bfe6301ba7

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8733956 [details]
MozReview Request: Bug 1259108 - Increase timeout of notifications from 12s to 20s to match parity with Chromium. r?mattn

Increasing notification timeout based on partner/end-user feedback, Aurora47+, Beta46+

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/407be5a3b4f2

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3260a9cc2c3