125912 - nsLocalFile implementation headers shouldn't be exported

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The nsLocalFile implementation headers shouldn't be exported.  This leads to
things like bug 116149 comment 23 through bug 116149 comment 28.

I'll attach a patch that ought to work, although I haven't tested it yet on
Linux and it should probably be tested on Windows and Mac as well...

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch that ought to work

Comment 2

[Doug Turner (:dougt)]

true.  Not sure why I did this in the first place.... i think it was to have
xpcom/build know about this file, but that is just a stupid way to do it.

Comment 3

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 4

[Conrad Carlen (not reading bugmail)]

That patch almost works. I made a similar patch before knowing about this one
:-( There's an occurance of the nsLocalFile CID (declared in nsLocalFile.h) in
nsInternetConfigService.cpp. I changed it to use a contact id string, and then
it worked.

Comment 5

[Doug Turner (:dougt)]

conrad, can you drive this into the tree?  Attach a patch, and I will review it.

Comment 6

[Conrad Carlen (not reading bugmail)]

Taking it.

Comment 7

[Conrad Carlen (not reading bugmail)]

-> 1.4b

Comment 8

[Conrad Carlen (not reading bugmail)]

Attachment: updated patch

Ran clobber builds on OSX and Windows with this.

Comment 9

[Conrad Carlen (not reading bugmail)]

Comment on attachment 120894 [details] [diff] [review]
updated patch

an r/sr from either of you is probably enough?

Comment 10

[Doug Turner (:dougt)]

Comment on attachment 120894 [details] [diff] [review]
updated patch

could you also move the NS_LOCAL_FILE_CID to xpcom/build/nsXPCOMCID.h?

with that r=dougt

Comment 11

[Magnus Melin [:mkmelin]]

This bug is WFM now...

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 120894 [details] [diff] [review]
updated patch

Cancelling r? since the patch is no longer needed