Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks 1 bug)

unspecified
mozilla48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

We can shrink keyCodeData for a tiny win.
uint8_t would actually be enough for both of the changed fields, but due to the
|char*| uint16_t results in the same value for sizeof(keyCodeData).
Attachment #8734038 - Flags: review?(bzbarsky)
Comment on attachment 8734038 [details] [diff] [review]
Shrink keyCodeData

r=me, though some static_asserts about the relevant sizeof and keycode values fitting in 16 bits would be good.
Attachment #8734038 - Flags: review?(bzbarsky) → review+
> r=me, though some static_asserts about the relevant sizeof and keycode
> values fitting in 16 bits would be good.

I checked -- GCC errors if either of the fields is ever assigned a value that's too large.
Blocks: 1254777
https://hg.mozilla.org/mozilla-central/rev/050be20c329f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.