Closed
Bug 1259187
Opened 9 years ago
Closed 9 years ago
crash in mozilla::CycleCollectedJSRuntime::CycleCollectedJSRuntime
Categories
(Core :: DOM: Workers, defect, P2)
Tracking
()
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
e10s | + | --- |
firefox46 | --- | wontfix |
firefox47 | --- | unaffected |
firefox48 | --- | unaffected |
People
(Reporter: elan, Unassigned)
References
Details
(Keywords: crash)
Crash Data
This bug was filed from the Socorro interface and is
report bp-6fe55baf-4a12-4c2d-9f0a-ab3ea2160312.
=============================================================
Reporter | ||
Comment 1•9 years ago
|
||
This impacts e10s, :naveed can we get an assignee?
Flags: needinfo?(nihsanullah)
Comment 2•9 years ago
|
||
This is just an out of memory crash. It looks like Firefox is trying to create a JS runtime for a worker, and it fails.
Comment 3•9 years ago
|
||
Actually, it looks like there aren't any crashes on versions more recently than 46. Maybe bug 1247122 fixed this (which landed in 47)? Andrea, does that make sense? I don't really understand what that other bug did.
Depends on: 1247122
Flags: needinfo?(amarchesini)
Comment 4•9 years ago
|
||
Oh I see, it looks like it made the worker creation fail if the runtime creation failed, rather than just crashing. If this is a problem on 46, maybe uplifting that other bug would make sense, at least to get cleaner beta experiment info.
Updated•9 years ago
|
Component: JavaScript: GC → DOM: Workers
Updated•9 years ago
|
Flags: needinfo?(nihsanullah)
Updated•9 years ago
|
status-firefox46:
--- → affected
status-firefox47:
--- → unaffected
(In reply to Andrew McCreight [:mccr8] from comment #4)
> Oh I see, it looks like it made the worker creation fail if the runtime
> creation failed, rather than just crashing. If this is a problem on 46,
> maybe uplifting that other bug would make sense, at least to get cleaner
> beta experiment info.
Right. The patch is probably pretty straightforward to uplift.
Comment 7•9 years ago
|
||
I don't think uplift is required. We've filed a bug for the OOM situation more generally with e10s, so I'm going to dup this.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Comment 8•9 years ago
|
||
Per your criteria in comment 0 of bug 1259512, I think this shouldn't be duped over. This crash happens when we fail to create a new JS runtime, which includes allocating a new GC nursery, which is a contiguous block that is WORKER_DEFAULT_NURSERY_SIZE bytes long. Currently, this is 1MB, qualifying this as an OOM | large.
Blocks: e10s-oom
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•9 years ago
|
Comment 10•9 years ago
|
||
I think at this point we're not going to backport anything for it to 46, and later versions are not affected, so I'll mark this WFM.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → WORKSFORME
Comment 11•9 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #8)
> Per your criteria in comment 0 of bug 1259512, I think this shouldn't be
> duped over. This crash happens when we fail to create a new JS runtime,
> which includes allocating a new GC nursery, which is a contiguous block that
> is WORKER_DEFAULT_NURSERY_SIZE bytes long. Currently, this is 1MB,
> qualifying this as an OOM | large.
Hey mccr8, how is this not affected by our oom problems? Are you saying that we'll address this in other bugs by reducing memory fragmentation, or did we land something somewhere that helps with this?
Flags: needinfo?(continuation)
Comment 12•9 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #11)
> Hey mccr8, how is this not affected by our oom problems? Are you saying that
> we'll address this in other bugs by reducing memory fragmentation, or did we
> land something somewhere that helps with this?
These OOM crashes happen when a page tries to create a new DOM worker and fails. On 46, we crash immediately when this happens. With the patch from bug 1247122, which is on 47 and later, we instead throw an exception and continue running. Thus this particular crash is no longer possible.
Flags: needinfo?(continuation)
You need to log in
before you can comment on or make changes to this bug.
Description
•