Closed
Bug 1259218
Opened 9 years ago
Closed 9 years ago
don't require arc4random_addrandom in libevent on Android
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla48
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.50 KB,
patch
|
jld
:
review+
|
Details | Diff | Splinter Review |
arc4random_addrandom has been removed in the r11 NDK; its presence in the libevent sources causes linking failures. But, fun fact, we don't even need to call the function that calls arc4random_addrandom, so we can just #ifdef out the calling function, as is done for OpenBSD.
|
Assignee | |
Comment 1•9 years ago
|
||
Patching patch files, as one does.
Attachment #8734074 -
Flags: review?(jld)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Sigh, committed too much from magit.
Attachment #8734075 -
Flags: review?(jld)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8734074 -
Attachment is obsolete: true
Attachment #8734074 -
Flags: review?(jld)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8734075 [details] [diff] [review]
don't use arc4random_addrandom on Android, since NDK r11 doesn't provide it
r=me, but… if we're not using this function, then couldn't we #if 0 or just delete it?
Attachment #8734075 -
Flags: review?(jld) → review+
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•