Closed
Bug 1259252
Opened 9 years ago
Closed 9 years ago
Add "Recently Closed" feature to history panel
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
4.0
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: bmunar, Assigned: bmunar)
References
Details
Attachments
(1 file)
|
48 bytes,
text/x-github-pull-request
|
bnicholson
:
review+
tecgirl
:
ui-review+
sleroux
:
feedback+
|
Details | Review |
1. Create the "Recently Closed" cell in the history panel
2. Create the Recently Closed page
3. Implement a way to store and display recently closed tabs
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → bmunar
|
|
Assignee | |
Updated•9 years ago
|
tracking-fxios:
--- → +
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8751476 -
Flags: ui-review?(randersen)
Attachment #8751476 -
Flags: review?(sleroux)
Attachment #8751476 -
Flags: review?(bnicholson)
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8751476 [details] [review]
PR - whoever gets to it first
Looking pretty good so far - left some code comments and questions on the PR.
Attachment #8751476 -
Flags: feedback+
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8751476 [details] [review]
PR - whoever gets to it first
Looks good! The clock icon is fuzzy, though. Check the resolution/display on that.
Attachment #8751476 -
Flags: ui-review?(randersen) → ui-review+
|
||
Updated•9 years ago
|
Attachment #8751476 -
Flags: review?(bnicholson) → feedback+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8751476 [details] [review]
PR - whoever gets to it first
second round
Attachment #8751476 -
Flags: review?(sleroux)
Attachment #8751476 -
Flags: review?(bnicholson)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8751476 [details] [review]
PR - whoever gets to it first
Getting there! I like how the recent tabs implementation is now contained in its own module in profile. Let's tweak it a bit more so it exposes actual typed RecentTab objects (instead of generic string dicts) to make this more OO.
Attachment #8751476 -
Flags: review?(bnicholson)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8751476 -
Flags: review?(bnicholson)
|
|
||
Updated•9 years ago
|
Attachment #8751476 -
Flags: review?(bnicholson)
Attachment #8751476 -
Flags: review+
Attachment #8751476 -
Flags: feedback+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
|
|
||
Updated•9 years ago
|
Attachment #8751476 -
Flags: review?(sleroux)
You need to log in
before you can comment on or make changes to this bug.
Description
•