1259255 - NS_RUNTIMEABORT and ipc::FatalError don't annotate crash reports in the child process

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Josh Matthews [:jdm]]

For example, there's http://hg.mozilla.org/releases/mozilla-beta/annotate/fb3494d06dfb/ipc/glue/ProtocolUtils.cpp#l332 which contains useful debugging information. Unfortunately we end up in http://hg.mozilla.org/releases/mozilla-beta/annotate/fb3494d06dfb/memory/mozalloc/mozalloc_abort.cpp#l33 which dumps the message on the floor if we're not looking at a terminal window. Could we call AnnotateCrashReport from here?

Comment 1

[Josh Matthews [:jdm]]

I guess the fact that it's in mozalloc could complicate that...

Comment 2

[Josh Matthews [:jdm]]

Looks like bug 1236108 is related prior art, but focuses strictly on providing a handler that's called when OOM occurs.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Josh Matthews [:jdm] from comment #2)
> Looks like bug 1236108 is related prior art, but focuses strictly on
> providing a handler that's called when OOM occurs.

I also added support for the "reason" string that is reported by AnnotateMozCrashReason. I *think* NS_RUNTIMEABORT uses that. This might work once bug 1256541 is merged.

Comment 4

[Josh Matthews [:jdm]]

You're right, it calls NS_DebugBreak which uses that.

Comment 5

[Josh Matthews [:jdm]]

No, that's a lie, it does not.

Comment 6

[Andrew McCreight [:mccr8]]

Bug 1049275 made it so that NS_RUNTIMEABORT doesn't annotate the crash report in the child process, but it seems like MOZ_CRASH is now doing thing, so maybe NS_RUNTIMEABORT could do the same thing? Or is MOZ_CRASH not safe to call from IPC code?

Comment 7

[Andrew McCreight [:mccr8]]

Bill looked at this a bit and I think this is easy to fix. Or at least improve.

Comment 8

[(not currently active) Ted Mielczarek]

MOZ_CRASH is always safe to call, it's just a macro expansion to a crash.

Comment 9

[Gabriele Svelto [:gsvelto] (PTO)]

This was fixed in bug 1412048.