Closed Bug 1259352 Opened 4 years ago Closed 4 years ago

check_prog should always fail when an explicit value was given on the command line or environment

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: glandium, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Even when we have allow_missing=True, we should fail if the user explicitly gave a value on the command line or environment that was tested to not exist.
Comment on attachment 8734256 [details]
MozReview Request: Bug 1259352 - Always fail check_prog if an explicit value was given on the command line or environment. r?ted

https://reviewboard.mozilla.org/r/42149/#review38717

I was actually wondering about this when writing the yasm check, good call! We could go even further and actually check if the file is executable, too.
Attachment #8734256 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/86f7d5108e83
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.