check_prog should always fail when an explicit value was given on the command line or environment

RESOLVED FIXED in Firefox 48

Status

RESOLVED FIXED
2 years ago
6 months ago

People

(Reporter: glandium, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48

Firefox Tracking Flags

(firefox48 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Even when we have allow_missing=True, we should fail if the user explicitly gave a value on the command line or environment that was tested to not exist.
(Reporter)

Updated

2 years ago
Blocks: 1257663
(Reporter)

Comment 1

2 years ago
Created attachment 8734256 [details]
MozReview Request: Bug 1259352 - Always fail check_prog if an explicit value was given on the command line or environment. r?ted

Review commit: https://reviewboard.mozilla.org/r/42149/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42149/
Attachment #8734256 - Flags: review?(ted)
Comment on attachment 8734256 [details]
MozReview Request: Bug 1259352 - Always fail check_prog if an explicit value was given on the command line or environment. r?ted

https://reviewboard.mozilla.org/r/42149/#review38717

I was actually wondering about this when writing the yasm check, good call! We could go even further and actually check if the file is executable, too.
Attachment #8734256 - Flags: review?(ted) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/86f7d5108e83
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.