check_prog should always fail when an explicit value was given on the command line or environment

RESOLVED FIXED in Firefox 48

Status

RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: glandium, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla48

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Even when we have allow_missing=True, we should fail if the user explicitly gave a value on the command line or environment that was tested to not exist.
(Reporter)

Updated

3 years ago
Blocks: 1257663
Comment on attachment 8734256 [details]
MozReview Request: Bug 1259352 - Always fail check_prog if an explicit value was given on the command line or environment. r?ted

https://reviewboard.mozilla.org/r/42149/#review38717

I was actually wondering about this when writing the yasm check, good call! We could go even further and actually check if the file is executable, too.
Attachment #8734256 - Flags: review?(ted) → review+

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/86f7d5108e83
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.