1259352 - check_prog should always fail when an explicit value was given on the command line or environment

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Even when we have allow_missing=True, we should fail if the user explicitly gave a value on the command line or environment that was tested to not exist.

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 1259352 - Always fail check_prog if an explicit value was given on the command line or environment. r?ted

Review commit: https://reviewboard.mozilla.org/r/42149/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/42149/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8734256 [details]
MozReview Request: Bug 1259352 - Always fail check_prog if an explicit value was given on the command line or environment. r?ted

https://reviewboard.mozilla.org/r/42149/#review38717

I was actually wondering about this when writing the yasm check, good call! We could go even further and actually check if the file is executable, too.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86f7d5108e83

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86f7d5108e83