Closed Bug 1259422 Opened 4 years ago Closed 4 years ago

Re-order entities in preferences.dtd to match Preferences dialog and remove unused strings

Categories

(SeaMonkey :: Preferences, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.45

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

()

Details

Attachments

(1 file)

The suite/locales/en-US/chrome/common/pref/preferences.dtd file is a bit tricky to maintain as there is no grouping of the entities or a proper alignment with the actual dialog window. Also, at least one entity (down.label) isn't referenced anywhere. Aim of this housekeeping bug is to clean this up and re-organize the file for better maintainability.

Bug 1258295 removes the policies.label entity already.
Attached patch Proposed changesSplinter Review
This patch introduces empty lines between individual categories and sorts the entities according to their order in the tree.

Unused entities offline.label (apparently replaced by offlineApps.label) and down.label (now download.label) are removed.

There is also focusSearch.key which is used in suite/common/bindings/prefwindow.xml#477, however Ctrl+F doesn't seem to do anything in the Preferences window. I'll leave this for a follow-up bug in case that binding is no longer used.

I'm also patching suite/locales/en-US/chrome/mailnews/pref/mailPrefsOverlay.dtd where the Mail & Newsgroup entities are hiding. No changes for Composer preferences.
Attachment #8734416 - Flags: review?(iann_bugzilla)
Comment on attachment 8734416 [details] [diff] [review]
Proposed changes

Oh, and this patch applies on top of bug 1258295 attachment 8734339 [details] [diff] [review].
Attachment #8734416 - Flags: review?(iann_bugzilla) → review+
Pushed to trunk, http://hg.mozilla.org/comm-central/rev/71fc89a6bae9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.45
(In reply to rsx11m from comment #1)
> There is also focusSearch.key which is used in suite/common/bindings/prefwindow.xml#477,
> however Ctrl+F doesn't seem to do anything in the Preferences window. I'll leave this
> for a follow-up bug in case that binding is no longer used.

This was introduced in bug 460694 to focus the search bar in Browser > Helper Applications, no other usage that I could see. Since this is handled in suite/common/bindings/prefwindow.xml it apparently has to be defined in the top level of the preferences.

Thus, it's still in use and functional, nothing else to do here.
You need to log in before you can comment on or make changes to this bug.