1259573 - Default favicon should be inverted for highlighted awesomebar entries

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Drew Willcoxon :adw]

(In reply to Stephen Horlander [:shorlander] from bug 1181078 comment #42)
> Also it would be good to invert the default favicon if we can.
> Do we have an inverted version?

Comment 1

[u428464]

See also bug 1238907 (there is a white globe here).

Comment 2

[Drew Willcoxon :adw]

Thanks Guillaume.

Stephen says the icons in that bug are fine.  They're png, unlike the other icons in the popup though.  The default favicon is used in other places besides the awesomebar, and I don't know if other consumers can safely use svg.  For example bug 1174284 says that svg doesn't work in OS X menus -- but bug 1218041 may have fixed it?  Anyway I'll try to see if svg would be OK.

Comment 3

[Drew Willcoxon :adw]

Attachment: MozReview Request: Bug 1259573 - Invert the default favicon for selected awesomebar popup entries. r?mak

This uses the png icons from bug 1238907.  I don't think it's a good idea to try and switch to svg since the default favicon is used pervasively throughout Firefox.

The icons live in toolkit, so this just sets the image of .ac-site-icon in toolkit's autocomplete.css.  Pretty simple I think.  This way we also get the high-res versions where appropriate, which does not happen currently.

Since the icons are the same across platforms, I created a new shared subdirectory.

Review commit: https://reviewboard.mozilla.org/r/46833/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46833/

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5950fb882bda

Comment 5

[Drew Willcoxon :adw]

The leaks on try are due to an unrelated commit that was backed out of fx-team shortly after I refreshed my local copy.

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8741919 [details]
MozReview Request: Bug 1259573 - Invert the default favicon for selected awesomebar popup entries. r?mak

https://reviewboard.mozilla.org/r/46833/#review44189

Comment 7

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/45f98cbddc01

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/45f98cbddc01