Closed Bug 1259667 Opened 8 years ago Closed 8 years ago

Clean up WidgetSimpleGestureEvent

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla49

Tracking Flags:

Tracking

Status

firefox48

---

affected

firefox49

---

fixed

People

(Reporter: masayuki, Assigned: tetsuharu, Mentored)

References

Details

(Whiteboard: [good first bug][for Gecko Inside #7 in Mozilla Japan])

Attachments

(5 files)

MozReview Request: Bug 1259667 - part1: reorder the padding of WidgetSimpleGestureEvent.r?masayuki 8 years ago Tetsuharu OHZEKI [:tetsuharu] (UTC+9) 58 bytes, text/x-review-board-request	masayuki : review+	Details
MozReview Request: Bug 1259667 - part2: rename WidgetSimpleGestureEvent.allowedDirections to mAllowedDirections. r?masayuki 8 years ago Tetsuharu OHZEKI [:tetsuharu] (UTC+9) 58 bytes, text/x-review-board-request	masayuki : review+	Details
MozReview Request: Bug 1259667 - part3: rename WidgetSimpleGestureEvent.direction to mDirection. r?masayuki 8 years ago Tetsuharu OHZEKI [:tetsuharu] (UTC+9) 58 bytes, text/x-review-board-request	masayuki : review+	Details
MozReview Request: Bug 1259667 - part4: rename WidgetSimpleGestureEvent.clickCount to mClickCount. r?masayuki 8 years ago Tetsuharu OHZEKI [:tetsuharu] (UTC+9) 58 bytes, text/x-review-board-request	masayuki : review+	Details
MozReview Request: Bug 1259667 - part5: rename WidgetSimpleGestureEvent.delta to mDelta. r?masayuki 8 years ago Tetsuharu OHZEKI [:tetsuharu] (UTC+9) 58 bytes, text/x-review-board-request	masayuki : review+	Details

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Description

•

8 years ago

See bug 1259654 comment 0 for the detail.

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 1

•

8 years ago

I'll take this.

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Updated

•

8 years ago

Assignee: nobody → saneyuki.s.snyk

Status: NEW → ASSIGNED

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Comment 2

•

8 years ago

Thanks. Could you move |double delta;| to the first or the last member too? The instance size must be same or increased from current size. But adding new member would be bad if we kept current order (e.g., adding new double member or uint64_t to the tail with current order).

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 3

•

8 years ago

Attached file MozReview Request: Bug 1259667 - part1: reorder the padding of WidgetSimpleGestureEvent.r?masayuki — Details

Review commit: https://reviewboard.mozilla.org/r/46943/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46943/

Attachment #8742139 - Flags: review?(masayuki)

Attachment #8742140 - Flags: review?(masayuki)

Attachment #8742141 - Flags: review?(masayuki)

Attachment #8742142 - Flags: review?(masayuki)

Attachment #8742143 - Flags: review?(masayuki)

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 4

•

8 years ago

Attached file MozReview Request: Bug 1259667 - part2: rename WidgetSimpleGestureEvent.allowedDirections to mAllowedDirections. r?masayuki — Details

Review commit: https://reviewboard.mozilla.org/r/46945/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46945/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 5

•

8 years ago

Attached file MozReview Request: Bug 1259667 - part3: rename WidgetSimpleGestureEvent.direction to mDirection. r?masayuki — Details

Review commit: https://reviewboard.mozilla.org/r/46947/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46947/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 6

•

8 years ago

Attached file MozReview Request: Bug 1259667 - part4: rename WidgetSimpleGestureEvent.clickCount to mClickCount. r?masayuki — Details

Review commit: https://reviewboard.mozilla.org/r/46949/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46949/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 7

•

8 years ago

Attached file MozReview Request: Bug 1259667 - part5: rename WidgetSimpleGestureEvent.delta to mDelta. r?masayuki — Details

Review commit: https://reviewboard.mozilla.org/r/46951/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46951/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 8

•

8 years ago

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbc656e8a4b9

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Comment 9

•

8 years ago

Comment on attachment 8742139 [details]
MozReview Request: Bug 1259667 - part1: reorder the padding of WidgetSimpleGestureEvent.r?masayuki

https://reviewboard.mozilla.org/r/46943/#review44015

Attachment #8742139 - Flags: review?(masayuki) → review+

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Comment 10

•

8 years ago

Comment on attachment 8742140 [details]
MozReview Request: Bug 1259667 - part2: rename WidgetSimpleGestureEvent.allowedDirections to mAllowedDirections. r?masayuki

https://reviewboard.mozilla.org/r/46945/#review44017

Attachment #8742140 - Flags: review?(masayuki) → review+

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Comment 11

•

8 years ago

Comment on attachment 8742141 [details]
MozReview Request: Bug 1259667 - part3: rename WidgetSimpleGestureEvent.direction to mDirection. r?masayuki

https://reviewboard.mozilla.org/r/46947/#review44019

Attachment #8742141 - Flags: review?(masayuki) → review+

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Comment 12

•

8 years ago

Comment on attachment 8742142 [details]
MozReview Request: Bug 1259667 - part4: rename WidgetSimpleGestureEvent.clickCount to mClickCount. r?masayuki

https://reviewboard.mozilla.org/r/46949/#review44021

Attachment #8742142 - Flags: review?(masayuki) → review+

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Updated

•

8 years ago

Attachment #8742143 - Flags: review?(masayuki) → review+

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Comment 13

•

8 years ago

Comment on attachment 8742143 [details]
MozReview Request: Bug 1259667 - part5: rename WidgetSimpleGestureEvent.delta to mDelta. r?masayuki

https://reviewboard.mozilla.org/r/46951/#review44027

::: widget/cocoa/nsChildView.mm:4253
(Diff revision 1)
>      return;
>    }
>  
>    // Setup the event.
>    WidgetSimpleGestureEvent geckoEvent(true, msg, mGeckoChild);
> -  geckoEvent.delta = deltaZ;
> +  geckoEvent.mDelta = deltaZ;

Interesting, using deltaZ...

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Comment 14

•

8 years ago

Thank you very much!

Masayuki Nakano [:masayuki] (he/him)(JST, +0900)

Reporter

Comment 15

•

8 years ago

tetsuharu-san, it fails to land the patches with autoland, could you rebase the patches, do |hg push review| again and kick the autoland from ReviewBoard?

Flags: needinfo?(saneyuki.s.snyk)

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 16

•

8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=597fff1c42ad

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 17

•

8 years ago

Comment on attachment 8742139 [details]
MozReview Request: Bug 1259667 - part1: reorder the padding of WidgetSimpleGestureEvent.r?masayuki

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46943/diff/1-2/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 18

•

8 years ago

Comment on attachment 8742140 [details]
MozReview Request: Bug 1259667 - part2: rename WidgetSimpleGestureEvent.allowedDirections to mAllowedDirections. r?masayuki

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46945/diff/1-2/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 19

•

8 years ago

Comment on attachment 8742141 [details]
MozReview Request: Bug 1259667 - part3: rename WidgetSimpleGestureEvent.direction to mDirection. r?masayuki

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46947/diff/1-2/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 20

•

8 years ago

Comment on attachment 8742142 [details]
MozReview Request: Bug 1259667 - part4: rename WidgetSimpleGestureEvent.clickCount to mClickCount. r?masayuki

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46949/diff/1-2/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 21

•

8 years ago

Comment on attachment 8742143 [details]
MozReview Request: Bug 1259667 - part5: rename WidgetSimpleGestureEvent.delta to mDelta. r?masayuki

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/46951/diff/1-2/

Tetsuharu OHZEKI [:tetsuharu] (UTC+9)

Assignee

Comment 22

•

8 years ago

I'm sorry to replay late. I just updated patches.

Flags: needinfo?(saneyuki.s.snyk)

Pulsebot

Comment 23

•

8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae4894a0c9bb
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a8436e77403
https://hg.mozilla.org/integration/mozilla-inbound/rev/94449914749b
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ba2b4f62757
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1f793376c1c

Carsten Book [:Tomcat]

Comment 24

•

8 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ae4894a0c9bb
https://hg.mozilla.org/mozilla-central/rev/3a8436e77403
https://hg.mozilla.org/mozilla-central/rev/94449914749b
https://hg.mozilla.org/mozilla-central/rev/6ba2b4f62757
https://hg.mozilla.org/mozilla-central/rev/a1f793376c1c

Status: ASSIGNED → RESOLVED

Closed: 8 years ago

status-firefox49: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla49

You need to log in before you can comment on or make changes to this bug.