Closed
Bug 1259683
Opened 8 years ago
Closed 8 years ago
./configure --help broken after bug 1257823
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(3 files)
0:00.65 File "/home/glandium/gecko/browser/../toolkit/moz.configure", line 36, in <module> 0:00.65 imply_option('--enable-profiling', jprof) 0:00.65 File "/home/glandium/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 467, in imply_option_impl 0:00.65 value = self._resolve(value, need_help_dependency=False) 0:00.65 File "/home/glandium/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 212, in _resolve 0:00.65 assert func in self._results 0:00.65 AssertionError
Assignee | ||
Comment 1•8 years ago
|
||
This is not related to the bug, but are drive-by cleanups. Review commit: https://reviewboard.mozilla.org/r/42397/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42397/
Attachment #8734630 -
Flags: review?(nalexander)
Assignee | ||
Comment 2•8 years ago
|
||
This was suggested during review, and was applied to 2 of the 3 patches where this applied, and the imply_option tests were left out. This fixes it. Review commit: https://reviewboard.mozilla.org/r/42399/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42399/
Attachment #8734631 -
Flags: review?(nalexander)
Assignee | ||
Comment 3•8 years ago
|
||
This also adds the same tests that exist for set_config and set_define and that would have caught the `configure --help` breakage this change fixes. Review commit: https://reviewboard.mozilla.org/r/42401/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/42401/
Attachment #8734632 -
Flags: review?(nalexander)
Updated•8 years ago
|
Attachment #8734630 -
Flags: review?(nalexander) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8734630 [details] MozReview Request: Bug 1259683 - Miscellaneous small cleanups in the mozbuild.configure module. r?nalexander https://reviewboard.mozilla.org/r/42397/#review39033 ::: python/mozbuild/mozbuild/configure/__init__.py:357 (Diff revision 1) > Templates allow to simplify repetitive constructs, or to implement > helper decorators and somesuch. > ''' > template, glob = self._prepare_function(func) > glob.update( > - advanced=self.advanced_impl, > + (k[:-5], getattr(self, k)) I've always liked `k:[-len('_impl')]` in these cases. Your call.
Comment 5•8 years ago
|
||
Comment on attachment 8734631 [details] MozReview Request: Bug 1259683 - Forgotten change to test_configure.py before landing bug 1257823. r?nalexander https://reviewboard.mozilla.org/r/42399/#review39035
Attachment #8734631 -
Flags: review?(nalexander) → review+
Updated•8 years ago
|
Attachment #8734632 -
Flags: review?(nalexander) → review+
Comment 6•8 years ago
|
||
Comment on attachment 8734632 [details] MozReview Request: Bug 1259683 - Don't make imply_option() do anything when --help is on the command line. r?nalexander https://reviewboard.mozilla.org/r/42401/#review39037 I missed it the first time through. And now it's tested!
https://hg.mozilla.org/integration/mozilla-inbound/rev/174b56d80f69 https://hg.mozilla.org/integration/mozilla-inbound/rev/e2fe62b540c6 https://hg.mozilla.org/integration/mozilla-inbound/rev/98fd214bd3f2
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/174b56d80f69 https://hg.mozilla.org/mozilla-central/rev/e2fe62b540c6 https://hg.mozilla.org/mozilla-central/rev/98fd214bd3f2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•