1259696 - WebGL crash: [@mozilla::WebGLTexture::CopyTexImage2D]

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: testcase

Tested with https://hg.mozilla.org/integration/mozilla-inbound/rev/39fb883bcd1c

Comment 1

[Christoph Diehl [:posidron]]

Attachment: callstack

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Check read buffer mode.

Check the read buffer mode in CopyTexImage.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8735763 [details] [diff] [review]
Check read buffer mode.

Review of attachment 8735763 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContext.h
@@ +1387,5 @@
>      RefPtr<const webgl::LinkedProgramInfo> mActiveProgramLinkInfo;
>  
>      bool ValidateFramebufferTarget(GLenum target, const char* const info);
>  
> +    GLenum mReadBufferMode;

READ_BUFFER state is attached to each framebuffer, not part of global state. (GLES 3.0.4 p256)

Comment 4

[Ethan Lin[:ethlin]]

Attachment: Check read buffer mode.

In this patch, I use the framebuffer's READ_BUFFER mode to do the check.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8736341 [details] [diff] [review]
Check read buffer mode.

Review of attachment 8736341 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLTextureUpload.cpp
@@ +1728,5 @@
> +    // GLES 3.0.4 p145:
> +    // "Calling CopyTexSubImage3D, CopyTexImage2D, or CopyTexSubImage2D will result in an
> +    //  INVALID_OPERATION error if any of the following conditions is true: READ_BUFFER
> +    //  is NONE"
> +    if (mContext->IsWebGL2() && srcMode == LOCAL_GL_NONE) {

Drop the IsWebGL2 part, since srcMode should always be non-NONE in WebGL 1.

@@ +1889,5 @@
> +    // GLES 3.0.4 p145:
> +    // "Calling CopyTexSubImage3D, CopyTexImage2D, or CopyTexSubImage2D will result in an
> +    //  INVALID_OPERATION error if any of the following conditions is true: READ_BUFFER
> +    //  is NONE"
> +    if (mContext->IsWebGL2() && srcMode == LOCAL_GL_NONE) {

Drop the IsWebGL2 part, since srcMode should always be non-NONE in WebGL 1.

Comment 6

[Ethan Lin[:ethlin]]

Attachment: Check read buffer mode. (carry r+: jgilbert)

Address jgilbert's comments.

Comment 7

[Ethan Lin[:ethlin]]

try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e992a93f3f2d

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53400e993cb8

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/53400e993cb8